all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] vm start: set minimum timeout of 300s if using PCI passthrough
Date: Wed,  3 May 2023 15:37:23 +0200	[thread overview]
Message-ID: <20230503133723.165739-1-f.weber@proxmox.com> (raw)

The default VM startup timeout is max(30, VM memory in GiB) seconds.
Multiple reports in the forum [0] [1] and the bug tracker [2] suggest
this is too short when using PCI passthrough with a large amount of VM
memory, since QEMU needs to map the whole memory during startup (see
comment #2 in [2]). As a result, VM startup fails with "got timeout".

To work around this, ensure that the startup timeout is at least 300s
in case the VM config contains at least one `hostpci[n]` option.

[0]: https://forum.proxmox.com/threads/83765/post-552071
[1]: https://forum.proxmox.com/threads/126398/post-552807
[2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---

Notes:
    An alternative workaround is offered by an unapplied patch series [3]
    of bug #3502 [2] that makes it possible to set VM-specific timeouts
    (also in the GUI). Users could use this option to manually set a
    higher timeout for VMs that use PCI passthrough. However, it is not
    immediately obvious that a higher timeout is necessary. Since the
    problem seems to come up somewhat frequently, I think it makes sense
    to have the heuristic choose a higher timeout by default.
    
    [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502
    [3]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055352.html

 PVE/QemuServer/Helpers.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
index e91f906..11897f4 100644
--- a/PVE/QemuServer/Helpers.pm
+++ b/PVE/QemuServer/Helpers.pm
@@ -160,6 +160,11 @@ sub config_aware_timeout {
 	$timeout = 150;
     }
 
+    # Users reported the default timeout being too short when using PCI passthrough
+    if (grep(/^hostpci[0-9]+$/, keys %$config) && $timeout < 300) {
+	$timeout = 300;
+    }
+
     return $timeout;
 }
 
-- 
2.30.2





             reply	other threads:[~2023-05-03 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 13:37 Friedrich Weber [this message]
2023-08-21  8:33 ` Fiona Ebner
2023-09-08 11:40   ` Friedrich Weber
2023-09-11  7:03     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503133723.165739-1-f.weber@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal