From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content
Date: Thu, 20 Apr 2023 10:06:16 +0200 [thread overview]
Message-ID: <20230420080616.836255-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230420080616.836255-1-d.csapak@proxmox.com>
this enables the user to sort the grid by multiple columns
simultaneously, e.g. by vmid and then by date
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sending as rfc because i'm not so sure about this.
on one hand, this allows to recreate the original sorting if users want
that, but the selection is a bit weird. there is no way to 'unsort'
columns again, it simply uses the last 3 columns that were clicked
especially with the last patch (statefulness) it becomes weird, but
maybe we want this more than we want it to be stateful?
www/manager6/storage/BackupView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index bb045f5b6..ebc476747 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -5,6 +5,7 @@ Ext.define('PVE.storage.BackupView', {
showColumns: ['name', 'notes', 'protected', 'date', 'format', 'size'],
+ multiColumnSort: true,
stateful: true,
stateId: 'storage-backup-content',
--
2.30.2
next prev parent reply other threads:[~2023-04-20 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:06 [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default Dominik Csapak
2023-04-20 8:06 ` [pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful Dominik Csapak
2023-04-22 7:21 ` Thomas Lamprecht
2023-04-20 8:06 ` Dominik Csapak [this message]
2023-04-20 13:39 ` [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content Aaron Lauterer
2023-04-22 7:21 ` Thomas Lamprecht
2023-04-22 7:38 ` [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default Thomas Lamprecht
2023-04-22 7:52 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420080616.836255-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal