all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation
Date: Mon, 17 Apr 2023 09:04:18 +0200	[thread overview]
Message-ID: <20230417070418.134721-1-f.gruenbichler@proxmox.com> (raw)

it causes severe slow downs on fast disks, and we still have other rsyncable
compressors available.

it was originally added based on wrong documentation that made the performance
impact look a lot smaller than it actually is.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    IMHO, we can always re-introduce it as configurable opt-in option if somebody
    really needs this combination.. and most things for which you might want
    rsyncable are better off just using PBS nowadays anyway.

 PVE/VZDump.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index a04837e7..f574950e 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -757,7 +757,7 @@ sub compressor_info {
 	    my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
 	    $zstd_threads = int(($cpuinfo->{cpus} + 1)/2);
 	}
-	return ("zstd --rsyncable --threads=${zstd_threads}", 'zst');
+	return ("zstd --threads=${zstd_threads}", 'zst');
     } else {
 	die "internal error - unknown compression option '$opt_compress'";
     }
-- 
2.30.2





             reply	other threads:[~2023-04-17  7:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  7:04 Fabian Grünbichler [this message]
2023-06-06 17:14 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417070418.134721-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal