all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com,
	pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 2/2] fix #4618: dark-mode: lighten critical/warning charts/gauges colors
Date: Fri, 14 Apr 2023 15:28:08 +0200	[thread overview]
Message-ID: <20230414132811.1485897-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230414132811.1485897-1-s.sterz@proxmox.com>

by increasing the lightness of these colors to to make them have the
same amount of lightness as the primary color.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/extjs/_progress.scss | 4 ++--
 src/proxmox-dark/scss/other/_charts.scss   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/proxmox-dark/scss/extjs/_progress.scss b/src/proxmox-dark/scss/extjs/_progress.scss
index 4f2bb49..5d5941c 100644
--- a/src/proxmox-dark/scss/extjs/_progress.scss
+++ b/src/proxmox-dark/scss/extjs/_progress.scss
@@ -11,9 +11,9 @@
 }
 
 .x-progress.warning .x-progress-bar {
-  background-color: $background-warning;
+  background-color: var(--pwt-gauge-warn);
 }
 
 .x-progress.critical .x-progress-bar {
-  background-color: $background-invalid;
+  background-color: var(--pwt-gauge-crit);
 }
diff --git a/src/proxmox-dark/scss/other/_charts.scss b/src/proxmox-dark/scss/other/_charts.scss
index 5c67282..26b0104 100644
--- a/src/proxmox-dark/scss/other/_charts.scss
+++ b/src/proxmox-dark/scss/other/_charts.scss
@@ -7,8 +7,8 @@
   --pwt-text-color: #{$text-color};
   --pwt-gauge-default: #{$primary-color};
   --pwt-gauge-back: #{$background-dark};
-  --pwt-gauge-warn: #{$background-warning};
-  --pwt-gauge-crit: #{$background-invalid};
+  --pwt-gauge-warn: #{adjust-color($background-warning, $lightness: lightness($primary-color))};
+  --pwt-gauge-crit: #{adjust-color($background-invalid, $lightness: lightness($primary-color))};
   --pwt-chart-primary: #{$primary-color};
   --pwt-chart-grid-stroke: #{$content-background-selected};
 }
-- 
2.30.2





WARNING: multiple messages have this Message-ID
From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com,
	pve-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit 2/2] fix #4618: dark-mode: lighten critical/warning charts/gauges colors
Date: Fri, 14 Apr 2023 15:28:08 +0200	[thread overview]
Message-ID: <20230414132811.1485897-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230414132811.1485897-1-s.sterz@proxmox.com>

by increasing the lightness of these colors to to make them have the
same amount of lightness as the primary color.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/extjs/_progress.scss | 4 ++--
 src/proxmox-dark/scss/other/_charts.scss   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/proxmox-dark/scss/extjs/_progress.scss b/src/proxmox-dark/scss/extjs/_progress.scss
index 4f2bb49..5d5941c 100644
--- a/src/proxmox-dark/scss/extjs/_progress.scss
+++ b/src/proxmox-dark/scss/extjs/_progress.scss
@@ -11,9 +11,9 @@
 }
 
 .x-progress.warning .x-progress-bar {
-  background-color: $background-warning;
+  background-color: var(--pwt-gauge-warn);
 }
 
 .x-progress.critical .x-progress-bar {
-  background-color: $background-invalid;
+  background-color: var(--pwt-gauge-crit);
 }
diff --git a/src/proxmox-dark/scss/other/_charts.scss b/src/proxmox-dark/scss/other/_charts.scss
index 5c67282..26b0104 100644
--- a/src/proxmox-dark/scss/other/_charts.scss
+++ b/src/proxmox-dark/scss/other/_charts.scss
@@ -7,8 +7,8 @@
   --pwt-text-color: #{$text-color};
   --pwt-gauge-default: #{$primary-color};
   --pwt-gauge-back: #{$background-dark};
-  --pwt-gauge-warn: #{$background-warning};
-  --pwt-gauge-crit: #{$background-invalid};
+  --pwt-gauge-warn: #{adjust-color($background-warning, $lightness: lightness($primary-color))};
+  --pwt-gauge-crit: #{adjust-color($background-invalid, $lightness: lightness($primary-color))};
   --pwt-chart-primary: #{$primary-color};
   --pwt-chart-grid-stroke: #{$content-background-selected};
 }
-- 
2.30.2





WARNING: multiple messages have this Message-ID
From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com,
	pve-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH widget-toolkit 2/2] fix #4618: dark-mode: lighten critical/warning charts/gauges colors
Date: Fri, 14 Apr 2023 15:28:08 +0200	[thread overview]
Message-ID: <20230414132811.1485897-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230414132811.1485897-1-s.sterz@proxmox.com>

by increasing the lightness of these colors to to make them have the
same amount of lightness as the primary color.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/extjs/_progress.scss | 4 ++--
 src/proxmox-dark/scss/other/_charts.scss   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/proxmox-dark/scss/extjs/_progress.scss b/src/proxmox-dark/scss/extjs/_progress.scss
index 4f2bb49..5d5941c 100644
--- a/src/proxmox-dark/scss/extjs/_progress.scss
+++ b/src/proxmox-dark/scss/extjs/_progress.scss
@@ -11,9 +11,9 @@
 }
 
 .x-progress.warning .x-progress-bar {
-  background-color: $background-warning;
+  background-color: var(--pwt-gauge-warn);
 }
 
 .x-progress.critical .x-progress-bar {
-  background-color: $background-invalid;
+  background-color: var(--pwt-gauge-crit);
 }
diff --git a/src/proxmox-dark/scss/other/_charts.scss b/src/proxmox-dark/scss/other/_charts.scss
index 5c67282..26b0104 100644
--- a/src/proxmox-dark/scss/other/_charts.scss
+++ b/src/proxmox-dark/scss/other/_charts.scss
@@ -7,8 +7,8 @@
   --pwt-text-color: #{$text-color};
   --pwt-gauge-default: #{$primary-color};
   --pwt-gauge-back: #{$background-dark};
-  --pwt-gauge-warn: #{$background-warning};
-  --pwt-gauge-crit: #{$background-invalid};
+  --pwt-gauge-warn: #{adjust-color($background-warning, $lightness: lightness($primary-color))};
+  --pwt-gauge-crit: #{adjust-color($background-invalid, $lightness: lightness($primary-color))};
   --pwt-chart-primary: #{$primary-color};
   --pwt-chart-grid-stroke: #{$content-background-selected};
 }
-- 
2.30.2





  parent reply	other threads:[~2023-04-14 13:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 13:28 [pve-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups - Round 6 Stefan Sterz
2023-04-14 13:28 ` [pmg-devel] " Stefan Sterz
2023-04-14 13:28 ` [pbs-devel] " Stefan Sterz
2023-04-14 13:28 ` [pve-devel] [PATCH widget-toolkit 1/2] dark-mode: adjust panel header tool icons Stefan Sterz
2023-04-14 13:28   ` [pmg-devel] " Stefan Sterz
2023-04-14 13:28   ` [pbs-devel] " Stefan Sterz
2023-04-14 13:28 ` Stefan Sterz [this message]
2023-04-14 13:28   ` [pmg-devel] [PATCH widget-toolkit 2/2] fix #4618: dark-mode: lighten critical/warning charts/gauges colors Stefan Sterz
2023-04-14 13:28   ` [pbs-devel] " Stefan Sterz
2023-04-14 13:28 ` [pbs-devel] [PATCH proxmox-backup 1/2] docs: fix api viewer dark theme path Stefan Sterz
2023-04-14 13:28 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: main view: rename "Theme" selector to "Color Theme" Stefan Sterz
2023-04-14 13:28 ` [pmg-devel] [PATCH pmg-gui 1/1] main view/quarantine: " Stefan Sterz
2023-05-17  9:53 ` [pve-devel] applied-series: [pbs-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups - Round 6 Thomas Lamprecht
2023-05-17  9:53   ` [pmg-devel] " Thomas Lamprecht
2023-05-17  9:53   ` [pbs-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414132811.1485897-3-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal