From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-apt 1/2] fallback to Release file for Origin retrieval
Date: Wed, 12 Apr 2023 09:17:57 +0200 [thread overview]
Message-ID: <20230412071758.3383292-1-f.gruenbichler@proxmox.com> (raw)
APT will not store the InRelease file in some cases, and some repositories
might not even have one in the first place.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/repositories/repository.rs | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/repositories/repository.rs b/src/repositories/repository.rs
index a5e3015..7a19af4 100644
--- a/src/repositories/repository.rs
+++ b/src/repositories/repository.rs
@@ -315,10 +315,13 @@ impl APTRepository {
pub fn get_cached_origin(&self) -> Result<Option<String>, Error> {
for uri in self.uris.iter() {
for suite in self.suites.iter() {
- let file = in_release_filename(uri, suite);
+ let mut file = release_filename(uri, suite, false);
if !file.exists() {
- continue;
+ file = release_filename(uri, suite, true);
+ if !file.exists() {
+ continue;
+ }
}
let raw = std::fs::read(&file)
@@ -354,17 +357,19 @@ impl APTRepository {
}
}
-/// Get the path to the cached InRelease file.
-fn in_release_filename(uri: &str, suite: &str) -> PathBuf {
+/// Get the path to the cached (In)Release file.
+fn release_filename(uri: &str, suite: &str, detached: bool) -> PathBuf {
let mut path = PathBuf::from(&crate::config::get().dir_state);
path.push(&crate::config::get().dir_state_lists);
- let filename = uri_to_filename(uri);
+ let encoded_uri = uri_to_filename(uri);
+ let filename = if detached { "Release" } else { "InRelease" };
path.push(format!(
- "{}_dists_{}_InRelease",
- filename,
+ "{}_dists_{}_{}",
+ encoded_uri,
suite.replace('/', "_"), // e.g. for buster/updates
+ filename,
));
path
--
2.30.2
next reply other threads:[~2023-04-12 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 7:17 Fabian Grünbichler [this message]
2023-04-12 7:17 ` [pve-devel] [PATCH proxmox-apt 2/2] fix #4653: (In)Release file: improve handling of special suites Fabian Grünbichler
2023-06-06 16:25 ` [pve-devel] applied-series: [PATCH proxmox-apt 1/2] fallback to Release file for Origin retrieval Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412071758.3383292-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.