all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/4] cfg2cmd: use actual backend names instead of removed tty and paraport aliases
Date: Mon,  3 Apr 2023 14:09:42 +0200	[thread overview]
Message-ID: <20230403120945.51924-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230403120945.51924-1-f.ebner@proxmox.com>

As described in:
https://qemu-project.gitlab.io/qemu/about/removed-features.html#chardev-backend-aliases-tty-and-parport-removed-in-8-0

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c1d0fd2d..c7caa163 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3794,7 +3794,7 @@ sub config_to_command {
 	    }
 	} else {
 	    die "no such serial device\n" if ! -c $path;
-	    push @$devices, '-chardev', "tty,id=serial$i,path=$path";
+	    push @$devices, '-chardev', "serial,id=serial$i,path=$path";
 	    push @$devices, '-device', "isa-serial,chardev=serial$i";
 	}
     }
@@ -3803,7 +3803,7 @@ sub config_to_command {
     for (my $i = 0; $i < $MAX_PARALLEL_PORTS; $i++)  {
 	if (my $path = $conf->{"parallel$i"}) {
 	    die "no such parallel device\n" if ! -c $path;
-	    my $devtype = $path =~ m!^/dev/usb/lp! ? 'tty' : 'parport';
+	    my $devtype = $path =~ m!^/dev/usb/lp! ? 'serial' : 'parallel';
 	    push @$devices, '-chardev', "$devtype,id=parallel$i,path=$path";
 	    push @$devices, '-device', "isa-parallel,chardev=parallel$i";
 	}
-- 
2.30.2





  reply	other threads:[~2023-04-03 12:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 12:09 [pve-devel] [PATCH-SERIES qemu-server] adapt to QEMU 8.0 removed and deprecated features Fiona Ebner
2023-04-03 12:09 ` Fiona Ebner [this message]
2023-04-03 12:09 ` [pve-devel] [PATCH qemu-server 2/4] cfg2cmd: replace deprecated no-acpi option with acpi=off machine flag Fiona Ebner
2023-04-03 12:09 ` [pve-devel] [PATCH qemu-server 3/4] cfg2cmd: replace deprecated no-hpet option with hpet=off " Fiona Ebner
2023-04-03 12:09 ` [pve-devel] [PATCH qemu-server 4/4] schema: avoid using deprecated -no-hpet in example for 'args' property Fiona Ebner
2023-06-06  6:35 ` [pve-devel] [PATCH-SERIES qemu-server] adapt to QEMU 8.0 removed and deprecated features Fiona Ebner
2023-06-07 15:40 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403120945.51924-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal