all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-storage 1/1] volume export: explicitly state unit of bandwidth limit
Date: Wed, 29 Mar 2023 14:34:35 +0200	[thread overview]
Message-ID: <20230329123436.2090248-5-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20230329123436.2090248-1-s.hanreich@proxmox.com>

Other places like replication explicitly state whether byte or bit
are used as a unit rather than only the abbreviation.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Could have gone for Bps instead, but I think this is more explicit
and all other places I could find are using the explicit unit as well.
Also, everything else is in lowercase so I decided to stick with that.

 PVE/Storage.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cec3996..b99ed35 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -752,7 +752,7 @@ my $volume_export_prepare = sub {
     my $cstream;
     if (defined($ratelimit_bps)) {
 	$cstream = [ '/usr/bin/cstream', '-t', $ratelimit_bps ];
-	$logfunc->("using a bandwidth limit of $ratelimit_bps bps for transferring '$volid'") if $logfunc;
+	$logfunc->("using a bandwidth limit of $ratelimit_bps bytes per second for transferring '$volid'") if $logfunc;
     }
 
     volume_snapshot($cfg, $volid, $snapshot) if $migration_snapshot;
-- 
2.30.2




  parent reply	other threads:[~2023-03-29 12:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 12:34 [pve-devel] [PATCH-SERIES storage/docs/guest-common/qemu-server/common] Improve and unify documentation of bwlimit parameter Stefan Hanreich
2023-03-29 12:34 ` [pve-devel] [PATCH pve-docs 1/1] backup: Fix wrong unit for bandwidth limit Stefan Hanreich
2023-03-29 12:34 ` [pve-devel] [PATCH pve-common 1/1] json schema: improve description of bwlimit parameter Stefan Hanreich
2023-03-29 12:34 ` [pve-devel] [PATCH qemu-server 1/1] qmrestore: " Stefan Hanreich
2023-03-29 12:34 ` Stefan Hanreich [this message]
2023-03-29 12:34 ` [pve-devel] [PATCH pve-guest-common 1/1] vzdump: " Stefan Hanreich
2023-06-06 15:57 ` [pve-devel] applied-series: [PATCH-SERIES storage/docs/guest-common/qemu-server/common] Improve and unify documentation " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329123436.2090248-5-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal