all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column
@ 2023-03-22  9:23 Aaron Lauterer
  2023-05-26  8:34 ` Aaron Lauterer
  2023-06-07 17:32 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Aaron Lauterer @ 2023-03-22  9:23 UTC (permalink / raw)
  To: pve-devel

The pool number is shown in a few places, having it easily accessible
can help to understand which pool a warning/error refers to.

For example, the PG ID consists of '{pool nr}.{pg nr}' and is shown in
every warning concerning that PG.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---

this is just a small quality of live patch as I wanted to quickly know
the pool nr after looking at some warnings.

 www/manager6/ceph/Pool.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 301a3f91..8de23ecf 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -234,6 +234,14 @@ Ext.define('PVE.node.Ceph.PoolList', {
     features: [{ ftype: 'summary' }],
 
     columns: [
+	{
+	    text: gettext('Pool #'),
+	    minWidth: 70,
+	    flex: 1,
+	    align: 'right',
+	    sortable: true,
+	    dataIndex: 'pool',
+	},
 	{
 	    text: gettext('Name'),
 	    minWidth: 120,
-- 
2.30.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column
  2023-03-22  9:23 [pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column Aaron Lauterer
@ 2023-05-26  8:34 ` Aaron Lauterer
  2023-06-07 17:32 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Aaron Lauterer @ 2023-05-26  8:34 UTC (permalink / raw)
  To: pve-devel

ping?

On 3/22/23 10:23, Aaron Lauterer wrote:
> The pool number is shown in a few places, having it easily accessible
> can help to understand which pool a warning/error refers to.
> 
> For example, the PG ID consists of '{pool nr}.{pg nr}' and is shown in
> every warning concerning that PG.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> this is just a small quality of live patch as I wanted to quickly know
> the pool nr after looking at some warnings.
> 
>   www/manager6/ceph/Pool.js | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
> index 301a3f91..8de23ecf 100644
> --- a/www/manager6/ceph/Pool.js
> +++ b/www/manager6/ceph/Pool.js
> @@ -234,6 +234,14 @@ Ext.define('PVE.node.Ceph.PoolList', {
>       features: [{ ftype: 'summary' }],
>   
>       columns: [
> +	{
> +	    text: gettext('Pool #'),
> +	    minWidth: 70,
> +	    flex: 1,
> +	    align: 'right',
> +	    sortable: true,
> +	    dataIndex: 'pool',
> +	},
>   	{
>   	    text: gettext('Name'),
>   	    minWidth: 120,




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: ceph: pool: add pool number as column
  2023-03-22  9:23 [pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column Aaron Lauterer
  2023-05-26  8:34 ` Aaron Lauterer
@ 2023-06-07 17:32 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-06-07 17:32 UTC (permalink / raw)
  To: Proxmox VE development discussion, Aaron Lauterer

Am 22/03/2023 um 10:23 schrieb Aaron Lauterer:
> The pool number is shown in a few places, having it easily accessible
> can help to understand which pool a warning/error refers to.
> 
> For example, the PG ID consists of '{pool nr}.{pg nr}' and is shown in
> every warning concerning that PG.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> this is just a small quality of live patch as I wanted to quickly know
> the pool nr after looking at some warnings.
> 
>  www/manager6/ceph/Pool.js | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-07 17:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22  9:23 [pve-devel] [PATCH manager] ui: ceph: pool: add pool number as column Aaron Lauterer
2023-05-26  8:34 ` Aaron Lauterer
2023-06-07 17:32 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal