all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"
Date: Tue, 21 Mar 2023 11:04:23 +0100	[thread overview]
Message-ID: <20230321100425.85065-1-w.bumiller@proxmox.com> (raw)

This looks horrible.

A *much* *much* better way to improve readability is to
simply set the opacity down to 0.5.

This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0.
---
I can't stand this.
Seriously.

 src/proxmox-dark/scss/extjs/_presentation.scss | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/proxmox-dark/scss/extjs/_presentation.scss b/src/proxmox-dark/scss/extjs/_presentation.scss
index 5fd35a9..2503368 100644
--- a/src/proxmox-dark/scss/extjs/_presentation.scss
+++ b/src/proxmox-dark/scss/extjs/_presentation.scss
@@ -1,8 +1,8 @@
 // The mask that is applied when the window is unaccessible (Login
 // screen, Loading, ...)
 .x-mask {
-  background-color: $background-darker;
-  opacity: 0.75;
+  background-color: black;
+  opacity: 0.85;
 }
 
 // Shadows of floating windows like window modals, form selectors and
@@ -10,5 +10,5 @@
 .x-css-shadow {
   // the additional styling from the pve css overwrites the setting on
   // the element with "!important", that's why we need it here.
-  box-shadow: $background-dark 0 -1px 15px 7px !important;
+  box-shadow: $background-darkest 0 0 5px !important;
 }
-- 
2.30.2





             reply	other threads:[~2023-03-21 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 10:04 Wolfgang Bumiller [this message]
2023-03-21 10:04 ` [pve-devel] [PATCH 2/3] dark-mode: reduce background mask opacity to 0.5 Wolfgang Bumiller
2023-03-21 10:04 ` [pve-devel] [PATCH 3/3] dark-mode: make shadow black Wolfgang Bumiller
2023-03-21 13:05 ` [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more" Thomas Lamprecht
2023-03-21 14:04   ` Stefan Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321100425.85065-1-w.bumiller@proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal