all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage
Date: Tue, 21 Mar 2023 10:16:10 +0100	[thread overview]
Message-ID: <20230321091610.1416089-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230321091610.1416089-1-d.csapak@proxmox.com>

the change handler of the edit config from a displayeditfield still
triggers, even if not shown/disabled. sadly this enabled another
editconfig part of a displayeditfield, which triggers an error
in the api

to fix that, simply check if this field is disabled before setting
the other fields value

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/storage/LvmThinEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
index c3b55d87d..63f1fd78f 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b/www/manager6/storage/LvmThinEdit.js
@@ -148,7 +148,7 @@ Ext.define('PVE.storage.LvmThinInputPanel', {
 		    },
 		    change: function(f, value) {
 			let vgField = this.up('inputpanel').lookup('thinPoolSelector');
-			if (vgField) {
+			if (vgField && !f.isDisabled()) {
 			    vgField.setDisabled(!value);
 			    vgField.setVG(value);
 			    vgField.setValue('');
-- 
2.30.2





  reply	other threads:[~2023-03-21  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21  9:16 [pve-devel] [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window Dominik Csapak
2023-03-21  9:16 ` Dominik Csapak [this message]
2023-03-21  9:37   ` [pve-devel] applied: [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage Thomas Lamprecht
2023-03-21  9:31 ` [pve-devel] applied: [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321091610.1416089-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal