all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content
Date: Fri, 10 Mar 2023 14:08:35 +0100	[thread overview]
Message-ID: <20230310130837.1188003-5-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com>

previously the dark theme used thicker borders in certain places to
space out the content a bit more. this removes them again to make the
appearance more consistent with "crisp".

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/abstracts/_mixins.scss |  7 -------
 src/proxmox-dark/scss/extjs/_toolbar.scss    |  2 +-
 src/proxmox-dark/scss/proxmox/_general.scss  | 13 -------------
 3 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/src/proxmox-dark/scss/abstracts/_mixins.scss b/src/proxmox-dark/scss/abstracts/_mixins.scss
index 570a783..4f226f2 100644
--- a/src/proxmox-dark/scss/abstracts/_mixins.scss
+++ b/src/proxmox-dark/scss/abstracts/_mixins.scss
@@ -1,10 +1,3 @@
-// A border to the left and on top of the content panels for the
-// selected resource
-@mixin content-border {
-  border-top: solid 3px $background-darkest;
-  border-left: solid 3px $background-darkest;
-}
-
 // selected items in dropdown etc
 @mixin selection {
   background-color: $selection-background-color;
diff --git a/src/proxmox-dark/scss/extjs/_toolbar.scss b/src/proxmox-dark/scss/extjs/_toolbar.scss
index 2ea8527..aa6ffc5 100644
--- a/src/proxmox-dark/scss/extjs/_toolbar.scss
+++ b/src/proxmox-dark/scss/extjs/_toolbar.scss
@@ -4,7 +4,7 @@
 
 .x-toolbar-default {
   background-color: $background-darker;
-  border: solid 3px $background-darkest;
+  border-color: $border-color-alt;
 
   &.x-docked-top {
     border-width: 1px;
diff --git a/src/proxmox-dark/scss/proxmox/_general.scss b/src/proxmox-dark/scss/proxmox/_general.scss
index 805a187..c319f6d 100644
--- a/src/proxmox-dark/scss/proxmox/_general.scss
+++ b/src/proxmox-dark/scss/proxmox/_general.scss
@@ -9,19 +9,6 @@ div[id^="versioninfo-"] + div[id^="panel-"] > div[id^="panel-"][id$="-bodyWrap"]
   border-color: transparent;
 }
 
-// border around the main datacenter view
-div[id^="PVE-dc-Config-"][id$="-body"],
-// border around the main pool view
-div[id^="pvePoolConfig-"][id$="-body"],
-// Container content config views
-div[id^="pveLXCConfig-"][id$="-body"],
-// VM content config views
-div[id^="PVE-qemu-Config-"][id$="-body"],
-div[id^="PVE-storage-Browser-"][id$="-body"],
-div[id^="PVE-node-Config-"][id$="-body"] {
-  @include content-border;
-}
-
 // Section header in the "My Settings" page
 .x-fieldset-header-default > .x-fieldset-header-text {
   color: $text-color;
-- 
2.30.2





  parent reply	other threads:[~2023-03-10 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 13:08 [pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer Stefan Sterz
2023-03-10 13:08 ` Stefan Sterz [this message]
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons Stefan Sterz
2023-03-11 16:54 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310130837.1188003-5-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal