From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background
Date: Fri, 10 Mar 2023 14:08:32 +0100 [thread overview]
Message-ID: <20230310130837.1188003-2-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com>
previously an "!important" was missing from the `background-color`
property. this meant that the background color wasn't properly
overridden. the "!important" is necessary as it is also used in the
light theme.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
src/proxmox-dark/scss/extjs/_grid.scss | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/proxmox-dark/scss/extjs/_grid.scss b/src/proxmox-dark/scss/extjs/_grid.scss
index 77872b0..3719fdc 100644
--- a/src/proxmox-dark/scss/extjs/_grid.scss
+++ b/src/proxmox-dark/scss/extjs/_grid.scss
@@ -96,8 +96,10 @@
.x-grid-cell,
.x-grid-rowwrap,
.x-grid-cell-rowbody {
+ // the "!important" is needed here, because crisp also sets this
+ // as important
+ background-color: $background-darker !important;
border-color: $border-color-alt;
- background-color: $background-darker;
}
}
--
2.30.2
next prev parent reply other threads:[~2023-03-10 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 13:08 [pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Stefan Sterz
2023-03-10 13:08 ` Stefan Sterz [this message]
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons Stefan Sterz
2023-03-11 16:54 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310130837.1188003-2-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.