From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details
Date: Wed, 8 Mar 2023 13:09:17 +0100 [thread overview]
Message-ID: <20230308120919.1646218-1-a.lauterer@proxmox.com> (raw)
The goal for this small series is to make it easier/more obvious to see
that there are potentially more details for a warning ceph is showing
by:
* having a tooltip with the details (limited in length)
* making the detail/info button more visible
changes since
v2:
* don't use arrow functions -> rework context in many places. mainly use
'this' now
* destroy tooltip when no detail text is present. This can easily be
tested by setting 'ceph osd set noout' for example
* guard show/hide on info button with '?'
v1:
* change creation of info window to use autoShow
* rework tooltip to:
* only destroy it when leaving the whole grid, use show/hide for all
other situations
* factor out text handling of newlines and max lines
* factor out updating and destroying into their own functions
* add more listeners
* hide it when hovering the info button
* auto update it whenever the store is updated
Aaron Lauterer (2):
ui: ceph: make the warning detail button stand out more
ui: ceph status: add tooltip with details to warnings
www/manager6/ceph/Status.js | 129 ++++++++++++++++++++++++++++--------
1 file changed, 103 insertions(+), 26 deletions(-)
--
2.30.2
next reply other threads:[~2023-03-08 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 12:09 Aaron Lauterer [this message]
2023-03-08 12:09 ` [pve-devel] [PATCH v3 manager 1/2] ui: ceph: make the warning detail button stand out more Aaron Lauterer
2023-03-08 12:09 ` [pve-devel] [PATCH v3 manager 2/2] ui: ceph status: add tooltip with details to warnings Aaron Lauterer
2023-03-08 16:05 ` [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details Thomas Lamprecht
2023-03-08 16:38 ` Aaron Lauterer
2023-03-08 16:43 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308120919.1646218-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.