all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v2 common/manager] Fix SSL Certificate and Key Upload Issues
Date: Fri,  3 Mar 2023 18:57:01 +0100	[thread overview]
Message-ID: <20230303175705.214121-1-m.carrara@proxmox.com> (raw)

This is v2 of https://lists.proxmox.com/pipermail/pve-devel/2023-February/055955.html

Changes from v1:
  - properly handle OpenSSL errors[0]
  - provide actually correct format changes[1]
  - include trailing comma[2]
  - make JavaScript code a little more concise[3]


[0] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055962.html
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055963.html
[2] Not on mailing list unfortunately, boo!
[3] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055961.html


pve-common:

Max Carrara (2):
  certificate: add subroutine that checks if cert and key match
  certificate: fix formatting and whitespace

 src/PVE/Certificate.pm | 74 +++++++++++++++++++++++++++++++++---------
 1 file changed, 59 insertions(+), 15 deletions(-)


pve-manager:

Max Carrara (2):
  fix #4552: certhelpers: check if custom cert and key match on change
  ui: cert upload: fix private key field sending empty string

 PVE/CertHelpers.pm                | 65 +++++++++++++++++++++++++++----
 www/manager6/node/Certificates.js |  3 ++
 2 files changed, 60 insertions(+), 8 deletions(-)

-- 
2.30.2





             reply	other threads:[~2023-03-03 17:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 17:57 Max Carrara [this message]
2023-03-03 17:57 ` [pve-devel] [PATCH v2 common 1/2] certificate: add subroutine that checks if cert and key match Max Carrara
2023-03-07 10:52   ` [pve-devel] applied: " Fabian Grünbichler
2023-03-07 17:47     ` Thomas Lamprecht
2023-03-03 17:57 ` [pve-devel] [PATCH v2 common 2/2] certificate: fix formatting and whitespace Max Carrara
2023-03-07 10:52   ` [pve-devel] applied: " Fabian Grünbichler
2023-03-03 17:57 ` [pve-devel] [PATCH v2 manager 1/2] fix #4552: certhelpers: check if custom cert and key match on change Max Carrara
2023-03-07 11:07   ` Fabian Grünbichler
2023-03-07 15:45     ` Max Carrara
2023-03-03 17:57 ` [pve-devel] [PATCH v2 manager 2/2] ui: cert upload: fix private key field sending empty string Max Carrara
2023-03-07 10:53   ` Fabian Grünbichler
2023-03-07 18:33   ` Thomas Lamprecht
2023-03-08  6:34     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303175705.214121-1-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal