all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container 2/3] net: Drop unused `firewall` argument to add_bridge_fdb()
Date: Wed,  1 Mar 2023 13:54:43 +0100	[thread overview]
Message-ID: <20230301125444.552793-3-c.heiss@proxmox.com> (raw)
In-Reply-To: <20230301125444.552793-1-c.heiss@proxmox.com>

PVE::Network::SDN::Zones::add_bridge_fdb() does not actually have a
`firewall` parameter, so drop it.

No functional changes.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 src/PVE/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 54ee0d9..cd0aeb1 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -923,7 +923,7 @@ sub net_tap_plug : prototype($$$$$$;$) {

     if ($have_sdn) {
 	PVE::Network::SDN::Zones::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate);
-	PVE::Network::SDN::Zones::add_bridge_fdb($iface, $opts->{mac}, $bridge, $firewall)
+	PVE::Network::SDN::Zones::add_bridge_fdb($iface, $opts->{mac}, $bridge)
 	    if defined($opts->{mac});
     } else {
 	PVE::Network::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts);
--
2.39.2





  parent reply	other threads:[~2023-03-01 12:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 12:54 [pve-devel] [PATCH network/container/qemu-server 0/3] Drop unused `firewall` argument to {add, del}_bridge_fdb() Christoph Heiss
2023-03-01 12:54 ` [pve-devel] [PATCH network 1/3] zones: " Christoph Heiss
2023-03-01 12:54 ` Christoph Heiss [this message]
2023-03-01 12:54 ` [pve-devel] [PATCH qemu-server 3/3] net: " Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301125444.552793-3-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal