From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error
Date: Wed, 15 Feb 2023 15:46:19 +0100 [thread overview]
Message-ID: <20230215144619.1475962-1-s.sterz@proxmox.com> (raw)
with the additional parenthesis eslint throws an error due to the
"no-extra-parens" rule that avoids unnecessary parenthesis. remove
them to get rid of the error.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
i am personally not too happy with this eslint requirement here, but
the widget toolkit won't build otherwise.
src/window/DiskSmart.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index b538ea1..be52a4e 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', {
{
name: 'real-value',
// FIXME remove with next major release (PBS 3.0)
- calculate: data => (data.normalized ?? false) ? data.raw : data.value,
+ calculate: data => data.normalized ?? false ? data.raw : data.value,
},
{
name: 'real-normalized',
--
2.30.2
next reply other threads:[~2023-02-15 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:46 Stefan Sterz [this message]
2023-02-15 15:03 ` Dominik Csapak
2023-02-15 15:22 ` Matthias Heiserer
2023-02-15 15:37 ` Dominik Csapak
2023-02-20 10:11 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215144619.1475962-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.