* [pve-devel] [PATCH v2 widget-toolkit] ui: SMART: show SMART data in correct columns
@ 2023-02-13 11:12 Matthias Heiserer
2023-02-14 9:49 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Heiserer @ 2023-02-13 11:12 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
Changes from v2:
make expression more compact
src/window/DiskSmart.js | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index 3c8040b..b538ea1 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -38,12 +38,12 @@ Ext.define('Proxmox.window.DiskSmart', {
},
{
text: gettext('Value'),
- dataIndex: 'raw',
+ dataIndex: 'real-value',
renderer: Ext.String.htmlEncode,
},
{
text: gettext('Normalized'),
- dataIndex: 'value',
+ dataIndex: 'real-normalized',
width: 60,
},
{
@@ -154,7 +154,18 @@ Ext.define('Proxmox.window.DiskSmart', {
Ext.define('pmx-smart-attribute', {
extend: 'Ext.data.Model',
fields: [
- { name: 'id', type: 'number' }, 'name', 'value', 'worst', 'threshold', 'flags', 'fail', 'raw',
+ { name: 'id', type: 'number' }, 'name', 'value', 'worst', 'threshold', 'flags', 'fail',
+ 'raw', 'normalized',
+ {
+ name: 'real-value',
+ // FIXME remove with next major release (PBS 3.0)
+ calculate: data => (data.normalized ?? false) ? data.raw : data.value,
+ },
+ {
+ name: 'real-normalized',
+ // FIXME remove with next major release (PBS 3.0)
+ calculate: data => data.normalized ?? data.raw,
+ },
],
idProperty: 'name',
});
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: Re: [PATCH v2 widget-toolkit] ui: SMART: show SMART data in correct columns
2023-02-13 11:12 [pve-devel] [PATCH v2 widget-toolkit] ui: SMART: show SMART data in correct columns Matthias Heiserer
@ 2023-02-14 9:49 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-02-14 9:49 UTC (permalink / raw)
To: Proxmox VE development discussion, Matthias Heiserer
On 13/02/2023 12:12, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v2:
> make expression more compact
>
>
> src/window/DiskSmart.js | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-14 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 11:12 [pve-devel] [PATCH v2 widget-toolkit] ui: SMART: show SMART data in correct columns Matthias Heiserer
2023-02-14 9:49 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.