From: Leo Nunner <l.nunner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI
Date: Wed, 8 Feb 2023 10:05:26 +0100 [thread overview]
Message-ID: <20230208090527.55278-2-l.nunner@proxmox.com> (raw)
In-Reply-To: <20230208090527.55278-1-l.nunner@proxmox.com>
makes it possible to optionally set the 'subdir' parameter when adding a
new CIFS storage.
Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
Changes from v1:
- use gettext for the Subdirectory label
www/manager6/storage/CIFSEdit.js | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/storage/CIFSEdit.js b/www/manager6/storage/CIFSEdit.js
index 71415401..8040bc85 100644
--- a/www/manager6/storage/CIFSEdit.js
+++ b/www/manager6/storage/CIFSEdit.js
@@ -129,6 +129,9 @@ Ext.define('PVE.storage.CIFSInputPanel', {
if (values.username?.length === 0) {
delete values.username;
}
+ if (values.subdir?.length === 0) {
+ delete values.subdir;
+ }
return me.callParent([values]);
},
@@ -216,6 +219,14 @@ Ext.define('PVE.storage.CIFSInputPanel', {
},
},
},
+ {
+ xtype: 'pmxDisplayEditField',
+ editable: me.isCreate,
+ name: 'subdir',
+ fieldLabel: gettext('Subdirectory'),
+ allowBlank: true,
+ emptyText: gettext('/some/path'),
+ },
];
me.callParent();
--
2.30.2
next prev parent reply other threads:[~2023-02-08 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:05 [pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories Leo Nunner
2023-02-08 9:05 ` Leo Nunner [this message]
2023-06-06 15:08 ` [pve-devel] applied: [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI Thomas Lamprecht
2023-02-08 9:05 ` [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend Leo Nunner
2023-03-21 11:32 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208090527.55278-2-l.nunner@proxmox.com \
--to=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.