all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC manager 1/1] fix #4442: node/qemu: Use firewallLogView panel for firewall logs
Date: Mon, 30 Jan 2023 10:07:14 +0100	[thread overview]
Message-ID: <20230130090715.349057-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20230130090715.349057-1-c.ebner@proxmox.com>

Using the firewall log view panel allows to filter not only by date, but also by
time (up to minute precision).

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/manager6/node/Config.js | 5 +++--
 www/manager6/qemu/Config.js | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index f8577b0f..31a1fc7f 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -387,12 +387,13 @@ Ext.define('PVE.node.Config', {
 	if (caps.nodes['Sys.Syslog']) {
 	    me.items.push(
 		{
-		    xtype: 'proxmoxLogView',
+		    xtype: 'proxmoxFirewallLogView',
 		    title: gettext('Log'),
 		    iconCls: 'fa fa-list',
 		    groups: ['firewall'],
 		    onlineHelp: 'chapter_pve_firewall',
-		    url: '/api2/extjs/nodes/' + nodename + '/firewall/log',
+		    url: '/nodes/' + nodename + '/firewall/log',
+		    log_select_timespan: true,
 		    itemId: 'firewall-fwlog',
 		},
 		{
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index 94c540c5..f78ebc67 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -383,8 +383,9 @@ Ext.define('PVE.qemu.Config', {
 		    iconCls: 'fa fa-list',
 		    onlineHelp: 'chapter_pve_firewall',
 		    itemId: 'firewall-fwlog',
-		    xtype: 'proxmoxLogView',
-		    url: '/api2/extjs' + base_url + '/firewall/log',
+		    xtype: 'proxmoxFirewallLogView',
+		    url: base_url + '/firewall/log',
+		    log_select_timespan: true,
 		},
 	    );
 	}
-- 
2.30.2





  parent reply	other threads:[~2023-01-30  9:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30  9:07 [pve-devel] [RFC widget-toolkit 0/2] fix #4442: Firewall log filtering Christian Ebner
2023-01-30  9:07 ` [pve-devel] [RFC widget-toolkit 1/2] DateTimeField: Extend and refactor to make field value bindable Christian Ebner
2023-01-30  9:07 ` Christian Ebner [this message]
2023-01-30  9:07 ` [pve-devel] [RFC widget-toolkit 2/2] fix #4442: panel: Add firewall log view panel Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130090715.349057-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal