all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/5] ui: BackupView: add scrolling overflow handler for the toolbar
Date: Wed, 18 Jan 2023 15:35:20 +0100	[thread overview]
Message-ID: <20230118143523.3587956-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230118143523.3587956-1-d.csapak@proxmox.com>

since we already have many elements here, and in our minimal resolution
of 1280x720 we don't see all elements any more.

reported in the forum:
https://forum.proxmox.com/threads/web-forms-extend-beyond-web-page-window-in-some-cases.120714

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/Backup.js | 71 +++++++++++++++++++++------------------
 1 file changed, 38 insertions(+), 33 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index d69370b69..0c4051b65 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -747,41 +747,46 @@ Ext.define('PVE.dc.BackupView', {
 	    viewConfig: {
 		trackOver: false,
 	    },
-	    tbar: [
-		{
-		    text: gettext('Add'),
-		    handler: function() {
-			var win = Ext.create('PVE.dc.BackupEdit', {});
-			win.on('destroy', reload);
-			win.show();
+	    dockedItems: [{
+		xtype: 'toolbar',
+		overflowHandler: 'scroller',
+		dock: 'top',
+		items: [
+		    {
+			text: gettext('Add'),
+			handler: function() {
+			    var win = Ext.create('PVE.dc.BackupEdit', {});
+			    win.on('destroy', reload);
+			    win.show();
+			},
 		    },
-		},
-		'-',
-		remove_btn,
-		edit_btn,
-		detail_btn,
-		'-',
-		run_btn,
-		'->',
-		noBackupJobWarning,
-		noBackupJobInfoButton,
-		'-',
-		{
-		    xtype: 'proxmoxButton',
-		    selModel: null,
-		    text: gettext('Schedule Simulator'),
-		    handler: () => {
-			let record = sm.getSelection()[0];
-			let schedule;
-			if (record) {
-			    schedule = record.data.schedule;
-			}
-			Ext.create('PVE.window.ScheduleSimulator', {
-			    schedule,
-			}).show();
+		    '-',
+		    remove_btn,
+		    edit_btn,
+		    detail_btn,
+		    '-',
+		    run_btn,
+		    '->',
+		    noBackupJobWarning,
+		    noBackupJobInfoButton,
+		    '-',
+		    {
+			xtype: 'proxmoxButton',
+			selModel: null,
+			text: gettext('Schedule Simulator'),
+			handler: () => {
+			    let record = sm.getSelection()[0];
+			    let schedule;
+			    if (record) {
+				schedule = record.data.schedule;
+			    }
+			    Ext.create('PVE.window.ScheduleSimulator', {
+				schedule,
+			    }).show();
+			},
 		    },
-		},
-	    ],
+		],
+	    }],
 	    columns: [
 		{
 		    header: gettext('Enabled'),
-- 
2.30.2





  reply	other threads:[~2023-01-18 14:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 14:35 [pve-devel] [PATCH manager 1/5] ui: reduce default size of Backup detail window Dominik Csapak
2023-01-18 14:35 ` Dominik Csapak [this message]
2023-01-19 17:13   ` [pve-devel] applied: [PATCH manager 2/5] ui: BackupView: add scrolling overflow handler for the toolbar Thomas Lamprecht
2023-01-18 14:35 ` [pve-devel] [PATCH manager 3/5] ui: ScheduleSimulator: split date and time into two columns Dominik Csapak
2023-01-19 17:13   ` [pve-devel] applied: " Thomas Lamprecht
2023-01-18 14:35 ` [pve-devel] [RFC PATCH manager 4/5] ui: ScheduleSimulator: add rownumberer column Dominik Csapak
2023-01-20  9:30   ` Thomas Lamprecht
2023-01-18 14:35 ` [pve-devel] [RFC PATCH manager 5/5] ui: ScheduleSimulator: add UTC checkbox Dominik Csapak
2023-01-19 17:16   ` Thomas Lamprecht
2023-01-19 17:11 ` [pve-devel] applied: [PATCH manager 1/5] ui: reduce default size of Backup detail window Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118143523.3587956-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal