Re: [pbs-devel] [PATCH proxmox-backup 4/4] ui: add 'keep configs' checkbox to datastore removal window

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Mon, Dec 19, 2022 at 03:13:26PM +0100, Hannes Laimer wrote:
> ... since the API already accepts a boolean for that.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/datastore/OptionView.js | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
> index 448cd4b3..d20c5d8a 100644
> --- a/www/datastore/OptionView.js
> +++ b/www/datastore/OptionView.js
> @@ -45,6 +45,11 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
>  	bind: {
>  	    value: '{destroyData}',
>  	},
> +    }, {
> +	xtype: 'proxmoxcheckbox',
> +	name: 'keep-job-configs',
> +	boxLabel: gettext("Keep configured jobs and permissions"),
> +	defaultValue: false,

^ This never gets passed along the API call.
We handle 'destroy-data' in `getParams`, so this probably needs to be
added there as well, but shouldn't this work automatically for these
simple cases? @Dominik

>      }, {
>  	xtype: 'component',
>  	reference: 'noteCmp',
> -- 
> 2.30.2