From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/1] Add pre/post-restore hooks to VMs
Date: Thu, 10 Nov 2022 16:33:41 +0100 [thread overview]
Message-ID: <20221110153341.494439-4-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20221110153341.494439-1-s.hanreich@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
PVE/API2/Qemu.pm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index a539b5c..3d4079e 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -888,6 +888,7 @@ __PACKAGE__->register_method({
die "$emsg $@" if $@;
my $restored_data = 0;
+ my $hook_executed = 0;
my $restorefn = sub {
my $conf = PVE::QemuConfig->load_config($vmid);
@@ -895,6 +896,9 @@ __PACKAGE__->register_method({
die "$emsg vm is running\n" if PVE::QemuServer::check_running($vmid);
+ PVE::GuestHelpers::exec_hookscript($conf, $vmid, 'pre-restore', 1);
+ $hook_executed = 1;
+
my $realcmd = sub {
my $restore_options = {
storage => $storage,
@@ -922,6 +926,8 @@ __PACKAGE__->register_method({
eval { PVE::QemuServer::template_create($vmid, $restored_conf) };
warn $@ if $@;
}
+
+ PVE::GuestHelpers::exec_hookscript($restored_conf, $vmid, 'post-restore');
};
# ensure no old replication state are exists
@@ -1016,10 +1022,10 @@ __PACKAGE__->register_method({
if (my $err = $@) {
eval { PVE::QemuConfig->remove_lock($vmid, 'create') };
warn $@ if $@;
- if ($restored_data) {
+ if ($hook_executed && $restored_data) {
warn "error after data was restored, VM disks should be OK but config may "
."require adaptions. VM $vmid state is NOT cleaned up.\n";
- } else {
+ } elsif ($hook_executed && !$restored_data) {
warn "error before or during data restore, some or all disks were not "
."completely restored. VM $vmid state is NOT cleaned up.\n";
}
--
2.30.2
next prev parent reply other threads:[~2022-11-10 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:33 [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks Stefan Hanreich
2022-11-10 15:33 ` [pve-devel] [PATCH pve-docs 1/1] add pre/post-restore events to example hookscript Stefan Hanreich
2022-11-11 13:58 ` Daniel Tschlatscher
2022-11-10 15:33 ` [pve-devel] [PATCH pve-container 1/1] Add pre/post-restore hooks to CTs Stefan Hanreich
2022-11-10 15:33 ` Stefan Hanreich [this message]
2022-11-11 13:58 ` [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks Daniel Tschlatscher
2022-11-11 14:02 ` Stefan Hanreich
2022-11-11 14:16 ` Daniel Tschlatscher
-- strict thread matches above, loose matches on Subject: below --
2022-09-22 13:19 [pve-devel] [PATCH pve-container/pve-docs/qemu-server 0/1] " Stefan Hanreich
2022-09-22 13:19 ` [pve-devel] [PATCH qemu-server 1/1] Add pre/post-restore hooks to VMs Stefan Hanreich
2022-09-22 13:54 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110153341.494439-4-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.