all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH-SERIES proxmox{, -mail-forward, -backup}/pve-manager] add proxmox-mail-forward helper binary
Date: Thu, 10 Nov 2022 11:58:53 +0100	[thread overview]
Message-ID: <20221110105853.nf77vn6fm6ajvtwg@casey.proxmox.com> (raw)
In-Reply-To: <20221021130252.176316-1-f.ebner@proxmox.com>

applied remaining patches

On Fri, Oct 21, 2022 at 03:02:43PM +0200, Fiona Ebner wrote:
> written in Rust, and replacing the pvemailforward binary in PVE. Can
> be used in PVE and PBS as well as in a mixed installations of the two.
> 
> To make reading the config files work, it is a setuid binary owned by
> root, but it sets the effective UID to the real UID after reading the
> configs, so parsing and sendmail invocation happen with lower
> privileges again (well, except if the binary was called by root
> directly).
> 
> The .forward file is updated during postinst as currently done in
> pve-manager. proxmox-mail-forward's postinst will not do anything
> when detecting a pvemailforward entry. Instead pve-manager is
> responsible for the switchover in PVE.
> 
> 
> proxmox-mail-forward needs a depenency bump for proxmox-section-config
> for the functionality added by the first patch.
> 
> proxmox-backup recommends proxmox-mail-forward (I felt a Recommends
> is more fitting, but feel free to change it) and pve-manager depends
> on proxmox-mail-forward are part of the series.
> 
> 
> proxmox:
> 
> Fiona Ebner (1):
>   section config: parse additional properties when schema allows it
> 
>  proxmox-section-config/src/lib.rs | 79 ++++++++++++++++++++++++++++++-
>  1 file changed, 78 insertions(+), 1 deletion(-)
> 
> 
> proxmox-mail-forward:
> 
> Fiona Ebner (3):
>   initial commit
>   add Debian packaging
>   d/postinst: register binary in .forward
> 
> 
> proxmox-backup:
> 
> Fiona Ebner (1):
>   fix #4287: d/control: recommend proxmox-mail-forward
> 
>  debian/control | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> pve-manager:
> 
> Fiona Ebner (4):
>   d/control: depend on proxmox-mail-forward
>   d/postinst: replace pvemailforward with proxmox-mail-forward
>   remove pvemailforward binary
>   d/control: drop ${shlibs:Depends} for pve-manager
> 
>  bin/Makefile             | 11 +++-------
>  bin/pvemailforward.c     | 17 ---------------
>  bin/pvemailforward.pl    | 45 ----------------------------------------
>  debian/control           |  2 +-
>  debian/lintian-overrides |  4 ----
>  debian/postinst          | 10 +++++++--
>  debian/rules             |  2 +-
>  7 files changed, 13 insertions(+), 78 deletions(-)
>  delete mode 100644 bin/pvemailforward.c
>  delete mode 100755 bin/pvemailforward.pl
> 
> -- 
> 2.30.2




WARNING: multiple messages have this Message-ID
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied-series: [PATCH-SERIES proxmox{, -mail-forward, -backup}/pve-manager] add proxmox-mail-forward helper binary
Date: Thu, 10 Nov 2022 11:58:53 +0100	[thread overview]
Message-ID: <20221110105853.nf77vn6fm6ajvtwg@casey.proxmox.com> (raw)
In-Reply-To: <20221021130252.176316-1-f.ebner@proxmox.com>

applied remaining patches

On Fri, Oct 21, 2022 at 03:02:43PM +0200, Fiona Ebner wrote:
> written in Rust, and replacing the pvemailforward binary in PVE. Can
> be used in PVE and PBS as well as in a mixed installations of the two.
> 
> To make reading the config files work, it is a setuid binary owned by
> root, but it sets the effective UID to the real UID after reading the
> configs, so parsing and sendmail invocation happen with lower
> privileges again (well, except if the binary was called by root
> directly).
> 
> The .forward file is updated during postinst as currently done in
> pve-manager. proxmox-mail-forward's postinst will not do anything
> when detecting a pvemailforward entry. Instead pve-manager is
> responsible for the switchover in PVE.
> 
> 
> proxmox-mail-forward needs a depenency bump for proxmox-section-config
> for the functionality added by the first patch.
> 
> proxmox-backup recommends proxmox-mail-forward (I felt a Recommends
> is more fitting, but feel free to change it) and pve-manager depends
> on proxmox-mail-forward are part of the series.
> 
> 
> proxmox:
> 
> Fiona Ebner (1):
>   section config: parse additional properties when schema allows it
> 
>  proxmox-section-config/src/lib.rs | 79 ++++++++++++++++++++++++++++++-
>  1 file changed, 78 insertions(+), 1 deletion(-)
> 
> 
> proxmox-mail-forward:
> 
> Fiona Ebner (3):
>   initial commit
>   add Debian packaging
>   d/postinst: register binary in .forward
> 
> 
> proxmox-backup:
> 
> Fiona Ebner (1):
>   fix #4287: d/control: recommend proxmox-mail-forward
> 
>  debian/control | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> pve-manager:
> 
> Fiona Ebner (4):
>   d/control: depend on proxmox-mail-forward
>   d/postinst: replace pvemailforward with proxmox-mail-forward
>   remove pvemailforward binary
>   d/control: drop ${shlibs:Depends} for pve-manager
> 
>  bin/Makefile             | 11 +++-------
>  bin/pvemailforward.c     | 17 ---------------
>  bin/pvemailforward.pl    | 45 ----------------------------------------
>  debian/control           |  2 +-
>  debian/lintian-overrides |  4 ----
>  debian/postinst          | 10 +++++++--
>  debian/rules             |  2 +-
>  7 files changed, 13 insertions(+), 78 deletions(-)
>  delete mode 100644 bin/pvemailforward.c
>  delete mode 100755 bin/pvemailforward.pl
> 
> -- 
> 2.30.2




  parent reply	other threads:[~2022-11-10 10:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 13:02 [pve-devel] " Fiona Ebner
2022-10-21 13:02 ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH proxmox 1/1] section config: parse additional properties when schema allows it Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-24 11:47   ` [pve-devel] applied: " Wolfgang Bumiller
2022-10-24 11:47     ` [pbs-devel] " Wolfgang Bumiller
2022-10-21 13:02 ` [pve-devel] [PATCH proxmox-mail-forward 1/3] initial commit Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-11-10 10:46   ` [pve-devel] applied: " Wolfgang Bumiller
2022-11-10 10:46     ` [pbs-devel] " Wolfgang Bumiller
2022-10-21 13:02 ` [pve-devel] [PATCH proxmox-mail-forward 2/3] add Debian packaging Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH proxmox-mail-forward 3/3] d/postinst: register binary in .forward Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH proxmox-backup 1/1] fix #4287: d/control: recommend proxmox-mail-forward Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-11-10 10:49   ` [pve-devel] applied: " Wolfgang Bumiller
2022-11-10 10:49     ` [pbs-devel] " Wolfgang Bumiller
2022-10-21 13:02 ` [pve-devel] [PATCH manager 1/4] d/control: depend on proxmox-mail-forward Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH manager 2/4] d/postinst: replace pvemailforward with proxmox-mail-forward Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH manager 3/4] remove pvemailforward binary Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-10-21 13:02 ` [pve-devel] [PATCH manager 4/4] d/control: drop ${shlibs:Depends} for pve-manager Fiona Ebner
2022-10-21 13:02   ` [pbs-devel] " Fiona Ebner
2022-11-10 11:11   ` [pve-devel] " Thomas Lamprecht
2022-11-10 11:11     ` [pbs-devel] " Thomas Lamprecht
2022-11-10 10:58 ` Wolfgang Bumiller [this message]
2022-11-10 10:58   ` [pbs-devel] applied-series: [PATCH-SERIES proxmox{, -mail-forward, -backup}/pve-manager] add proxmox-mail-forward helper binary Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110105853.nf77vn6fm6ajvtwg@casey.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal