From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-backup/common/storage v4] improve file-restore timeout behaviour
Date: Thu, 10 Nov 2022 11:36:28 +0100 [thread overview]
Message-ID: <20221110103634.2177856-1-d.csapak@proxmox.com> (raw)
this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout
and enables/disables the automatic increasing of memory depending
on the users privileges
depends (i'll add it to the seperate patches too)
pve-storage 1/3 fixes the currently broken error output and
does not depend on the rest of the series
pve-storage 2/3 depends on pve-common 1/2
pve-storage 3/3 depends on pve-common 2/2
pve-common 2/2 depends on proxmox-backup
changes from v3:
* don't hardcode the timeout parameter in pve-common, but make it a
hash were we explicitely extract the timeout
* split the pve-storage commit into two, one for handling the error
format and one for the timeout
* add patches to handle the dynamic memory behaviour
changes from v2:
* couple the error format to 'ouput-format' instead of 'json-error'
* remove 'error' property from 'error json object' (was redundant)
* always expect an error when we get an object and always treat
it as ok when we get a list
changes from v1:
* rebased on master
* moved the json-error and timeout directly into pve-common (hardcoded)
since there is only one usage of that function
proxmox-backup:
Dominik Csapak (1):
file-restore: make dynamic memory behaviour controllable
proxmox-file-restore/src/block_driver.rs | 10 +++-
proxmox-file-restore/src/block_driver_qemu.rs | 6 ++-
proxmox-file-restore/src/main.rs | 54 +++++++++++++++++--
3 files changed, 61 insertions(+), 9 deletions(-)
pve-common:
Dominik Csapak (2):
PBSClient: file_restore_list: add extraParams and use timeout
PBSClient: add optional 'dynamic-memory' parameter to file-restore
commands
src/PVE/PBSClient.pm | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
pve-storage:
Dominik Csapak (3):
api: FileRestore: decode and return proper error of file-restore
listing
api: FileRestore: make use of file-restores and guis timeout mechanism
api: FileRestore: allow automatic memory increase for privileged users
PVE/API2/Storage/FileRestore.pm | 48 +++++++++++++++++++++++++++------
1 file changed, 40 insertions(+), 8 deletions(-)
--
2.30.2
WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup/common/storage v4] improve file-restore timeout behaviour
Date: Thu, 10 Nov 2022 11:36:28 +0100 [thread overview]
Message-ID: <20221110103634.2177856-1-d.csapak@proxmox.com> (raw)
this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout
and enables/disables the automatic increasing of memory depending
on the users privileges
depends (i'll add it to the seperate patches too)
pve-storage 1/3 fixes the currently broken error output and
does not depend on the rest of the series
pve-storage 2/3 depends on pve-common 1/2
pve-storage 3/3 depends on pve-common 2/2
pve-common 2/2 depends on proxmox-backup
changes from v3:
* don't hardcode the timeout parameter in pve-common, but make it a
hash were we explicitely extract the timeout
* split the pve-storage commit into two, one for handling the error
format and one for the timeout
* add patches to handle the dynamic memory behaviour
changes from v2:
* couple the error format to 'ouput-format' instead of 'json-error'
* remove 'error' property from 'error json object' (was redundant)
* always expect an error when we get an object and always treat
it as ok when we get a list
changes from v1:
* rebased on master
* moved the json-error and timeout directly into pve-common (hardcoded)
since there is only one usage of that function
proxmox-backup:
Dominik Csapak (1):
file-restore: make dynamic memory behaviour controllable
proxmox-file-restore/src/block_driver.rs | 10 +++-
proxmox-file-restore/src/block_driver_qemu.rs | 6 ++-
proxmox-file-restore/src/main.rs | 54 +++++++++++++++++--
3 files changed, 61 insertions(+), 9 deletions(-)
pve-common:
Dominik Csapak (2):
PBSClient: file_restore_list: add extraParams and use timeout
PBSClient: add optional 'dynamic-memory' parameter to file-restore
commands
src/PVE/PBSClient.pm | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
pve-storage:
Dominik Csapak (3):
api: FileRestore: decode and return proper error of file-restore
listing
api: FileRestore: make use of file-restores and guis timeout mechanism
api: FileRestore: allow automatic memory increase for privileged users
PVE/API2/Storage/FileRestore.pm | 48 +++++++++++++++++++++++++++------
1 file changed, 40 insertions(+), 8 deletions(-)
--
2.30.2
next reply other threads:[~2022-11-10 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:36 Dominik Csapak [this message]
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-10 10:36 ` [pve-devel] [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 8:29 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 8:29 ` [pbs-devel] applied: " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH common v4 1/2] PBSClient: file_restore_list: add extraParams and use timeout Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:27 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:27 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH common v4 2/2] PBSClient: add optional 'dynamic-memory' parameter to file-restore commands Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 1/3] api: FileRestore: decode and return proper error of file-restore listing Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:27 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:27 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 2/3] api: FileRestore: make use of file-restores and guis timeout mechanism Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:28 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:28 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 3/3] api: FileRestore: allow automatic memory increase for privileged users Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110103634.2177856-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.