all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v1 2/2] ui: add javascript source to `OnlineHelpInfo.js` prerequisites
Date: Tue,  8 Nov 2022 16:01:30 +0100	[thread overview]
Message-ID: <20221108150130.2415229-2-s.sterz@proxmox.com> (raw)
In-Reply-To: <20221108150130.2415229-1-s.sterz@proxmox.com>

by adding the javascript files as prerequisites, the
`OnlineHelpInfo.js` will get re-generated if a new `onlineHelp` key
is used. thus, this avoids an issue were valid keys might not get
mapped correctly because the info in `OnlineHelpInfo.js` wasn't
updated.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
i stubled accross while fixing the bug mentioned in the previous 
commit. feel free to drop this, though.

 www/manager6/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index d16770b1..5938c7f5 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -304,7 +304,7 @@ pvemanagerlib.js: .lint-incremental OnlineHelpInfo.js ${JSSRC}
 	cat OnlineHelpInfo.js ${JSSRC} >$@.tmp
 	mv $@.tmp $@
 
-OnlineHelpInfo.js: /usr/bin/asciidoc-pve
+OnlineHelpInfo.js: /usr/bin/asciidoc-pve ${JSSRC}
 	/usr/bin/asciidoc-pve scan-extjs ${JSSRC} >$@.tmp
 	mv $@.tmp $@
 
-- 
2.30.2





  reply	other threads:[~2022-11-08 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 15:01 [pve-devel] [PATCH manager v1 1/2] fix #4328: make help buttons in the markdown editor window work again Stefan Sterz
2022-11-08 15:01 ` Stefan Sterz [this message]
2022-11-08 15:28   ` [pve-devel] applied: [PATCH manager v1 2/2] ui: add javascript source to `OnlineHelpInfo.js` prerequisites Thomas Lamprecht
2022-11-08 15:31 ` [pve-devel] [PATCH manager v1 1/2] fix #4328: make help buttons in the markdown editor window work again Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108150130.2415229-2-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal