From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH] spam quarantine controller: fix args when calling the parent multiSelect
Date: Mon, 7 Nov 2022 13:18:49 +0100 [thread overview]
Message-ID: <20221107121849.1323453-1-t.lamprecht@proxmox.com> (raw)
arguments needs to be an array, often we call with all of ours, iow.
using `arguments` which itself is an array already.
Both, manual construction and just a passing `arguments` have their
advantage and disadvantage, e.g., if either the inheriting or
bequesting class becomes more specialized, but most of the time using
`arguments` is more future proof.
Fixes: e66c888 ("quarantine: refactor spamquarantine controller")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
avoids an spurious undefined when selecting multiple emails.
js/SpamQuarantine.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
index 388fc02..7487c8f 100644
--- a/js/SpamQuarantine.js
+++ b/js/SpamQuarantine.js
@@ -51,7 +51,7 @@ Ext.define('PMG.SpamQuarantineController', {
spam.setDisabled(true);
spam.setPressed(false);
me.lookupReference('spaminfo').setVisible(false);
- me.callParent(selection);
+ me.callParent(arguments);
},
toggleSpamInfo: function(btn) {
--
2.30.2
reply other threads:[~2022-11-07 12:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107121849.1323453-1-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.