From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v3 0/5] add 'sync-level' to datatore tuning options
Date: Thu, 20 Oct 2022 09:40:53 +0200 [thread overview]
Message-ID: <20221020074058.717152-1-d.csapak@proxmox.com> (raw)
adds a sync-level option to the datastore tuning option, so that
the user can decide which level of file consitency is wanted, and
afterwards set the default to 'filesystem'
changes from v2:
* rebase on master
* fix typos in documentation
changes from v1:
* rebase on master
* reword documentation to be slightly less opinionated about which
option is better
changes from RFC:
* seperate introducing of the option and changing the default
* renaming to DatastoreFSyncLevel
* adding more and better comments + docs
* saving the whole level and not only a bool in the datastore/chunk_store
* adding a fsync on the dir handle for the 'file' case in insert_chunk
* split the change to 'replace_file' into seperate patch
the first patch is mostly unrelated, but it introduces a place where
we can document the option, and could be applied independent from
the remaining patches of this series.
the second patch only changes the use of replace_file in insert_chunk,
so that could also be applied independently.
Dominik Csapak (5):
docs: add information about chunk order option for datastores
pbs-datastore: chunk_store: use replace_file in insert_chunk
datastore: implement sync-level tuning for datastores
docs: add documentation about the 'sync-level' tuning
datastore: make 'filesystem' the default sync-level
docs/storage.rst | 59 ++++++++++++++++++++++++++++
pbs-api-types/src/datastore.rs | 37 ++++++++++++++++++
pbs-datastore/src/chunk_store.rs | 66 +++++++++++++++++++++++---------
pbs-datastore/src/datastore.rs | 39 +++++++++++++++++--
src/api2/backup/environment.rs | 2 +
src/api2/config/datastore.rs | 9 ++++-
6 files changed, 187 insertions(+), 25 deletions(-)
--
2.30.2
next reply other threads:[~2022-10-20 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 7:40 Dominik Csapak [this message]
2022-10-20 7:40 ` [pbs-devel] [PATCH proxmox-backup v3 1/5] docs: add information about chunk order option for datastores Dominik Csapak
2022-10-20 7:40 ` [pbs-devel] [PATCH proxmox-backup v3 2/5] pbs-datastore: chunk_store: use replace_file in insert_chunk Dominik Csapak
2022-10-20 7:40 ` [pbs-devel] [PATCH proxmox-backup v3 3/5] datastore: implement sync-level tuning for datastores Dominik Csapak
2022-10-20 13:09 ` Wolfgang Bumiller
2022-10-20 7:40 ` [pbs-devel] [PATCH proxmox-backup v3 4/5] docs: add documentation about the 'sync-level' tuning Dominik Csapak
2022-10-20 7:40 ` [pbs-devel] [PATCH proxmox-backup v3 5/5] datastore: make 'filesystem' the default sync-level Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020074058.717152-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal