* [pve-devel] [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options
@ 2022-10-17 13:24 Leo Nunner
2022-11-16 12:17 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Leo Nunner @ 2022-10-17 13:24 UTC (permalink / raw)
To: pve-devel
Changing the read-only status of a disk is not possible through QMP, so
it needs to be exempt from the hotpluggable values as to notify the
user.
Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4e85dd0..08a172d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5213,7 +5213,8 @@ sub vmconfig_update_disk {
safe_string_ne($drive->{iothread}, $old_drive->{iothread}) ||
safe_string_ne($drive->{queues}, $old_drive->{queues}) ||
safe_string_ne($drive->{cache}, $old_drive->{cache}) ||
- safe_string_ne($drive->{ssd}, $old_drive->{ssd})) {
+ safe_string_ne($drive->{ssd}, $old_drive->{ssd}) ||
+ safe_string_ne($drive->{ro}, $old_drive->{ro})) {
die "skip\n";
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options
2022-10-17 13:24 [pve-devel] [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options Leo Nunner
@ 2022-11-16 12:17 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-16 12:17 UTC (permalink / raw)
To: Proxmox VE development discussion, Leo Nunner
Am 17/10/2022 um 15:24 schrieb Leo Nunner:
> Changing the read-only status of a disk is not possible through QMP, so
> it needs to be exempt from the hotpluggable values as to notify the
> user.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> PVE/QemuServer.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-16 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 13:24 [pve-devel] [PATCH qemu-server] fix #4284: add read-only to non-hotpluggable disk options Leo Nunner
2022-11-16 12:17 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal