From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH-SERIES qemu(-server)/guest-common/manager/docs] make QEMU's max-workers setting configurable as a vzdump setting
Date: Mon, 10 Oct 2022 13:10:29 +0200 [thread overview]
Message-ID: <20221010111029.q2m6lbuc333rfvbr@casey.proxmox.com> (raw)
In-Reply-To: <20221003135211.183340-1-f.ebner@proxmox.com>
applied series
On Mon, Oct 03, 2022 at 03:52:03PM +0200, Fiona Ebner wrote:
> A few users reported IO-related issues during backup after upgrading
> to PVE 7.x and using a modified QEMU build with max-workers reduced to
> 8 instead of 16 helped them [0].
>
> Other BackupPerf settings are not exposed, see the qemu patch for why.
>
> Introduces a more general 'performance' property string as a vzdump
> setting to be expanded in the future. And in the long run, existing
> performance settings like bwlimit could be moved into there.
>
> To detect if the currently running QEMU supports the setting, the
> query-proxmox-support QMP command is used. If not supported, a
> warning is printed and the setting is ignored.
>
> All but the last documentation patches are independent. The recently
> created dedicated section for jobs is expanded and the introductory
> section for backups is updated to mention PBS. The last patch mentions
> the new performance/max-workers setting.
>
> [0]: https://forum.proxmox.com/threads/113790/
>
> Dependency bump manager -> guest-common is needed for the new
> $PROPERTY_STRING hash.
>
>
> qemu:
>
> Fiona Ebner (1):
> PVE Backup: allow passing max-workers performance setting
>
> block/monitor/block-hmp-cmds.c | 4 +++-
> pve-backup.c | 18 +++++++++++++-----
> qapi/block-core.json | 9 +++++++--
> 3 files changed, 23 insertions(+), 8 deletions(-)
>
>
> guest-common:
>
> Fiona Ebner (1):
> vzdump: add 'performance' property string as a setting
>
> src/PVE/VZDump/Common.pm | 42 ++++++++++++++++++++++++++++++----------
> 1 file changed, 32 insertions(+), 10 deletions(-)
>
>
> qemu-server:
>
> Fiona Ebner (1):
> vzdump: set max-workers QMP option when specified and supported
>
> PVE/VZDump/QemuServer.pm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>
> manager:
>
> Fiona Ebner (1):
> vzdump: handle new 'performance' property string
>
> PVE/API2/VZDump.pm | 9 +++++----
> PVE/Jobs/VZDump.pm | 23 ++++++++++-------------
> PVE/VZDump.pm | 12 ++++++++++++
> configs/vzdump.conf | 1 +
> www/manager6/dc/Backup.js | 8 +++++---
> 5 files changed, 33 insertions(+), 20 deletions(-)
>
>
> docs:
>
> Fiona Ebner (4):
> backup: rework storage section, mentioning and recommending PBS
> backup: expand section for jobs
> backup: merge sections describing jobs
> backup: mention max-workers performance setting
>
> vzdump.adoc | 61 +++++++++++++++++++++++++++++++++++------------------
> 1 file changed, 40 insertions(+), 21 deletions(-)
>
> --
> 2.30.2
prev parent reply other threads:[~2022-10-10 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 13:52 [pve-devel] " Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH qemu 1/1] PVE Backup: allow passing max-workers performance setting Fiona Ebner
2022-10-10 10:54 ` [pve-devel] applied: " Wolfgang Bumiller
2022-10-03 13:52 ` [pve-devel] [PATCH guest-common 1/1] vzdump: add 'performance' property string as a setting Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH qemu-server 1/1] vzdump: set max-workers QMP option when specified and supported Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH manager 1/1] vzdump: handle new 'performance' property string Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH docs 1/4] backup: rework storage section, mentioning and recommending PBS Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH docs 2/4] backup: expand section for jobs Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH docs 3/4] backup: merge sections describing jobs Fiona Ebner
2022-10-03 13:52 ` [pve-devel] [PATCH docs 4/4] backup: mention max-workers performance setting Fiona Ebner
2022-10-10 11:10 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010111029.q2m6lbuc333rfvbr@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.