all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES docs/(guest-)common/qemu-server/container/manager] cpuunits improvements
Date: Fri,  7 Oct 2022 14:41:37 +0200	[thread overview]
Message-ID: <20221007124156.110246-1-f.ebner@proxmox.com> (raw)

This series does multiple things, all related to cpuunits:

* Updates the documentation in pve-docs and pve-container for the
cgroup v2 cpuunits defaults and limits, while still mentioning the old
values that apply to legacy cgroup v1 hosts. qemu-server is already
updated.

* Move the get_cpuunits() helper from qemu-server to guest-common and
re-use it for containers. Makes behavior consistent with VMs and
allows starting existing containers with an out-of-range value. This
requires dependency bumps qemu-server,pve-container -> guest-common.

* Drop an unused parameter for change_cpu_shares(). Here technically,
a Breaks from common -> pve-container,qemu-server is needed, before
we can introduce a new parameter.

* Clamp cpuunits value already when setting via API.

* Broadcast the node's cgroup version as a pmxcfs kv entry. This is
the v2 of that patch, changes are noted there and use the value in
the UI to dynamically show the correct defaults and limits.


docs:

Fiona Ebner (2):
  qm: resource limits: update systemd setting name for cpuunits
  pct/qm: update cpuunits default

 pct.adoc |  5 +++--
 qm.adoc  | 14 +++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)


guest-common

Fiona Ebner (1):
  helpers: move get_cpuunits helper from qemu-server

 src/PVE/GuestHelpers.pm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)


container:

Fiona Ebner (7):
  config: cpuunits: drop description for outdated special value
  change cpu shares: hard-code cgroupv1 default parameter
  config: cpuunits: update default description
  use helper from guest-common for cpuunits
  config: replace mentions of "VM" with "container"
  change cpu shares: drop superfluous parameter
  api: create/update vm: clamp cpuunit value

 src/PVE/API2/LXC.pm        |  3 +++
 src/PVE/API2/LXC/Config.pm |  4 ++++
 src/PVE/LXC.pm             |  5 ++---
 src/PVE/LXC/Config.pm      | 19 +++++++++++--------
 4 files changed, 20 insertions(+), 11 deletions(-)


qemu-server:

Fiona Ebner (3):
  move get_cpuunits helper to guest-common
  change cpu shares: drop superfluous parameter
  api: create/update vm: clamp cpuunit value

 PVE/API2/Qemu.pm  |  6 ++++++
 PVE/QemuServer.pm | 23 ++++-------------------
 2 files changed, 10 insertions(+), 19 deletions(-)


common:

Fiona Ebner (1):
  change cpu shares: drop unused $cgroupv1_default parameter

 src/PVE/CGroup.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


manager:

Fiona Ebner (5):
  ui: lxc: cpu edit: drop superfluous delete_if_default
  ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default()
  ui: lxc/qemu: cpu edit: use emptyText for cpuunits
  cluster resources: add cgroup-mode to node properties
  ui: lxc/qemu: cpu edit: make cpuunits depend on node's cgroup version

 PVE/API2/Cluster.pm                | 12 +++++++++
 PVE/Service/pvestatd.pm            | 16 ++++++++++++
 www/manager6/lxc/CreateWizard.js   |  8 ++++++
 www/manager6/lxc/ResourceEdit.js   | 39 +++++++++++++++++++++++-------
 www/manager6/lxc/Resources.js      |  8 +++++-
 www/manager6/qemu/CreateWizard.js  |  8 ++++++
 www/manager6/qemu/HardwareView.js  |  8 +++++-
 www/manager6/qemu/ProcessorEdit.js | 34 ++++++++++++++++++++------
 8 files changed, 114 insertions(+), 19 deletions(-)

-- 
2.30.2





             reply	other threads:[~2022-10-07 12:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 12:41 Fiona Ebner [this message]
2022-10-07 12:41 ` [pve-devel] [PATCH docs 1/2] qm: resource limits: update systemd setting name for cpuunits Fiona Ebner
2022-10-19 12:04   ` [pve-devel] applied: " Thomas Lamprecht
2022-10-07 12:41 ` [pve-devel] [PATCH docs 2/2] pct/qm: update cpuunits default Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH guest-common 1/1] helpers: move get_cpuunits helper from qemu-server Fiona Ebner
2022-10-19 12:04   ` Thomas Lamprecht
2022-10-07 12:41 ` [pve-devel] [PATCH container 1/7] config: cpuunits: drop description for outdated special value Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH container 2/7] change cpu shares: hard-code cgroupv1 default parameter Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH container 3/7] config: cpuunits: update default description Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH container 4/7] use helper from guest-common for cpuunits Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH container 5/7] config: replace mentions of "VM" with "container" Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [RFC container 6/7] change cpu shares: drop superfluous parameter Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [RFC container 7/7] api: create/update vm: clamp cpuunit value Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH qemu-server 1/3] move get_cpuunits helper to guest-common Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [RFC qemu-server 2/3] change cpu shares: drop superfluous parameter Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [RFC qemu-server 3/3] api: create/update vm: clamp cpuunit value Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [RFC common 1/1] change cpu shares: drop unused $cgroupv1_default parameter Fiona Ebner
2022-11-07 15:30   ` [pve-devel] applied: " Thomas Lamprecht
2022-10-07 12:41 ` [pve-devel] [PATCH manager 1/5] ui: lxc: cpu edit: drop superfluous delete_if_default Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH manager 2/5] ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default() Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH manager 3/5] ui: lxc/qemu: cpu edit: use emptyText for cpuunits Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH v2 manager 4/5] cluster resources: add cgroup-mode to node properties Fiona Ebner
2022-11-02 12:24   ` Fiona Ebner
2022-10-07 12:41 ` [pve-devel] [PATCH manager 5/5] ui: lxc/qemu: cpu edit: make cpuunits depend on node's cgroup version Fiona Ebner
2022-11-08 15:27 ` [pve-devel] partially-applied-series: [PATCH-SERIES docs/(guest-)common/qemu-server/container/manager] cpuunits improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007124156.110246-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal