From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs
Date: Fri, 30 Sep 2022 14:38:00 +0200 [thread overview]
Message-ID: <20220930123802.772865-1-s.hrdlicka@proxmox.com> (raw)
V1 -> V2:
# pve-storage
* removed because patch is not needed
# pve-manager (1/3)
* remove storage controller from V1
* added custom ComboBox with API URL & setNodeName function
* added scan node selection for iSCSI
* scan node selection field no longer send to server
## (optional) pve-manager (2/3): cleanup related files
* var to let statement change
* some indentation
## ((very) optional) pve-manager (3/3): cleanup all var statements
* replaces all var with let statements
V2 -> V3:
# pve-manager (1/2)
* fix broken interface (broken in V2 )
* improve tooltip
* replace jNodeSelector function with class object
(PVE.panel.StorageBaseWithNodeSelector)
# other things:
* removed very optional cleanup
* nothing changed for "Base storage" selector. It is still possible to
select for example an iSCSI device only availabe on one node that
isn't availabe on the other ones. I wasn't sure if this should be
changed in this context as well.
V3 -> V4:
# pve-manager (1/2)
* "localhost" is set for "Scan Node"
* if another node is selcted and the "X" (clear) is used, localhost is
set as the value again
* use lookupReference
* moved used template literals for building path strings
V4 -> V5:
# pve-manager (1/2)
* s/lookupReference/lookup/
* move ComboBoxSetStoreNode & StrageScanNodeSelector
to www/manager6/form
* move array pushes to initialization of array
V5 -> V6:
# pve-manager (1/2)
* set default value of "Scan node" to Proxmox.NodeName
* don't allow empty "Scan node"
Stefan Hrdlicka (2):
fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes
cleanup: "var" to "let", fix some indentation in related files
www/manager6/Makefile | 2 +
www/manager6/form/ComboBoxSetStoreNode.js | 16 +++++
www/manager6/form/StorageScanNodeSelector.js | 31 +++++++++
www/manager6/storage/Base.js | 11 +--
www/manager6/storage/IScsiEdit.js | 35 +++++++---
www/manager6/storage/LVMEdit.js | 43 +++++++++---
www/manager6/storage/LvmThinEdit.js | 70 ++++++++++++++------
www/manager6/storage/ZFSPoolEdit.js | 51 +++++++++-----
8 files changed, 199 insertions(+), 60 deletions(-)
create mode 100644 www/manager6/form/ComboBoxSetStoreNode.js
create mode 100644 www/manager6/form/StorageScanNodeSelector.js
--
2.30.2
next reply other threads:[~2022-09-30 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 12:38 Stefan Hrdlicka [this message]
2022-09-30 12:38 ` [pve-devel] [PATCH V6 pve-manager 1/2] fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes Stefan Hrdlicka
2022-09-30 12:38 ` [pve-devel] [PATCH V6 pve-manager 2/2] cleanup: "var" to "let", fix some indentation in related files Stefan Hrdlicka
2022-10-21 9:24 ` [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs Dominik Csapak
2022-12-13 12:12 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930123802.772865-1-s.hrdlicka@proxmox.com \
--to=s.hrdlicka@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal