all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server v4 0/2] qmeventd: improve shutdown behaviour
@ 2022-09-23  9:51 Dominik Csapak
  2022-09-23  9:51 ` [pve-devel] [PATCH qemu-server v4 1/2] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dominik Csapak @ 2022-09-23  9:51 UTC (permalink / raw)
  To: pve-devel

includes the following improvements:
* increases 'force cleanup' timeout to 60s (from 5)
* saves individual timeout for each vm
* don't force cleanup for vms where normal cleanup worked
* sending QMP quit instead of SIGTERM (less log noise)

changes from v3:
* merge CleanupData into Client (pidfd,timeout) and use that for the
   forced_cleanup list
* close pidfd also in cleanup_client (and remove itself from the
   forced_cleanup list)
* guard the sigkill with a check for timeout != 0
* with those changes patch 2/3 is not necessary anymore

changes from v2:
* change from cast of the function to cast of the parameters
* don't copy the variable on the stack in 'sigkill'

changes from v1:
* remove 'alarm' calls altogether and use epoll_waits' timeout mechanic
   instead
* call 'time()' only once and give it as user data to the function
* change the function singatures and cast on callsite with '(GFunc)'
   for the g_slist_foreach calls
* change to <s> for the usage output for timeouts

Dominik Csapak (2):
  qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
  qmeventd: send QMP 'quit' command instead of SIGTERM

 qmeventd/qmeventd.c | 112 ++++++++++++++++++++++++--------------------
 qmeventd/qmeventd.h |   8 ++--
 2 files changed, 65 insertions(+), 55 deletions(-)

-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-23 10:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23  9:51 [pve-devel] [PATCH qemu-server v4 0/2] qmeventd: improve shutdown behaviour Dominik Csapak
2022-09-23  9:51 ` [pve-devel] [PATCH qemu-server v4 1/2] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
2022-09-23  9:51 ` [pve-devel] [PATCH qemu-server v4 2/2] qmeventd: send QMP 'quit' command instead of SIGTERM Dominik Csapak
2022-09-23 10:20 ` [pve-devel] applied-series: [PATCH qemu-server v4 0/2] qmeventd: improve shutdown behaviour Wolfgang Bumiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal