From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v3 0/3] qmeventd: improve shutdown behaviour
Date: Fri, 23 Sep 2022 10:30:07 +0200 [thread overview]
Message-ID: <20220923083010.946543-1-d.csapak@proxmox.com> (raw)
includes the following improvements:
* increases 'force cleanup' timeout to 60s (from 5)
* saves individual timeout for each vm
* don't force cleanup for vms where normal cleanup worked
* sending QMP quit instead of SIGTERM (less log noise)
changes from v2:
* change from cast of the function to cast of the parameters
* don't copy the variable on the stack in 'sigkill'
changes from v1:
* remove 'alarm' calls altogether and use epoll_waits' timeout mechanic
instead
* call 'time()' only once and give it as user data to the function
* change the function singatures and cast on callsite with '(GFunc)'
for the g_slist_foreach calls
* change to <s> for the usage output for timeouts
Dominik Csapak (3):
qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
qmeventd: cancel 'forced cleanup' when normal cleanup succeeds
qmeventd: send QMP 'quit' command instead of SIGTERM
qmeventd/qmeventd.c | 118 +++++++++++++++++++++++++++-----------------
qmeventd/qmeventd.h | 2 +
2 files changed, 75 insertions(+), 45 deletions(-)
--
2.30.2
next reply other threads:[~2022-09-23 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 8:30 Dominik Csapak [this message]
2022-09-23 8:30 ` [pve-devel] [PATCH qemu-server v3 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
2022-09-23 8:30 ` [pve-devel] [PATCH qemu-server v3 2/3] qmeventd: cancel 'forced cleanup' when normal cleanup succeeds Dominik Csapak
2022-09-23 8:30 ` [pve-devel] [PATCH qemu-server v3 3/3] qmeventd: send QMP 'quit' command instead of SIGTERM Dominik Csapak
2022-09-23 8:36 ` [pve-devel] [PATCH qemu-server v3 0/3] qmeventd: improve shutdown behaviour Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923083010.946543-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal