From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH V2 pve-container 3/8] adapt behavior for detaching/removing a mount point
Date: Mon, 12 Sep 2022 17:25:02 +0200 [thread overview]
Message-ID: <20220912152507.3498492-4-s.hrdlicka@proxmox.com> (raw)
In-Reply-To: <20220912152507.3498492-1-s.hrdlicka@proxmox.com>
detach of a mount point with a removed underlying storage causes it to
be labeled as a an 'unused disk'
remove of a 'unused disk' with a removed underlying storage causes it to
be removed from the configuration
Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
---
src/PVE/LXC/Config.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index b4b0261..7917863 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1423,7 +1423,10 @@ sub vmconfig_apply_pending {
$class->add_unused_volume($conf, $mp->{volume})
if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1);
}
- } elsif ($opt =~ m/^unused(\d+)$/) {
+ } elsif (
+ $opt =~ m/^unused(\d+)$/
+ && PVE::Storage::storage_exists($storecfg, $conf->{$opt})
+ ) {
PVE::LXC::delete_mountpoint_volume($storecfg, $vmid, $conf->{$opt})
if !$class->is_volume_in_use($conf, $conf->{$opt}, 1, 1);
}
--
2.30.2
next prev parent reply other threads:[~2022-09-12 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 15:24 [pve-devel] [PATCH V2 pve-storage/pve-container/qemu-server/pve-manager 0/8] fix #3711 & adapt drive detach/remove behavior Stefan Hrdlicka
2022-09-12 15:25 ` [pve-devel] [PATCH V2 pve-storage 1/8] add a storage_exists function Stefan Hrdlicka
2022-11-08 17:09 ` Thomas Lamprecht
2022-09-12 15:25 ` [pve-devel] [PATCH V2 pve-container 2/8] fix #3711: enable delete of LXC container Stefan Hrdlicka
2022-11-08 17:14 ` Thomas Lamprecht
2022-09-12 15:25 ` Stefan Hrdlicka [this message]
2022-09-12 15:25 ` [pve-devel] [PATCH V2 pve-container 4/8] cleanup: remove spaces from empty lines Stefan Hrdlicka
2022-09-12 15:25 ` [pve-devel] [PATCH V2 qemu-server 5/8] add ignore-storage-errors attribute for removing VM with missing storage Stefan Hrdlicka
2022-09-12 15:25 ` [pve-devel] [PATCH V2 qemu-server 6/8] adapt behavior for detaching drives to deatching container mount points Stefan Hrdlicka
2022-09-12 15:25 ` [pve-devel] [PATCH V2 qemu-server 7/8] cleanup: shorten line Stefan Hrdlicka
2022-09-12 15:25 ` [pve-devel] [PATCH V2 pve-manager 8/8] fix #3711: enable removing container with non existent storage Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912152507.3498492-4-s.hrdlicka@proxmox.com \
--to=s.hrdlicka@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.