[pve-devel] [PATCH manager 0/2] minor improvements to pvereport

[pve-devel] [PATCH manager 0/2] minor improvements to pvereport

[Stoiko Ivanov]

these two patches add small improvements to pvereport

Stoiko Ivanov (2):
  report: add proxmox-boot-tool status output
  report: stabilize order of guests and network

 PVE/Report.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.30.2

[pve-devel] [PATCH manager 1/2] report: add proxmox-boot-tool status output

[Stoiko Ivanov]

while needed seldomly we had a few cases recently where this would
have saved the user and us one roundtrip.

adding to storage, to be close to the `findmnt` output (which usually
tells us if the system is booted in efi or legacy mode)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
alternatively could also be added to the block device section

 PVE/Report.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index e88cfecd..3c61c1e4 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -55,6 +55,7 @@ my $init_report_cmds = sub {
 		'cat /etc/fstab',
 		'findmnt --ascii',
 		'df --human -T',
+		'proxmox-boot-tool status',
 	    ],
 	},
 	'virtual guests' => {
-- 
2.30.2

[pve-devel] [PATCH manager 2/2] report: stabilize order of guests and network

[Stoiko Ivanov]

both categories have '40' as their order - leading to random swaps
between those 2 categories in the actual report.

I only increased the order of network, instead of renumerating all
succeeding categories by 10 (mostly for better readability of the
patch)

Suggested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/Report.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index 3c61c1e4..b8bceb24 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -68,7 +68,7 @@ my $init_report_cmds = sub {
 	    ],
 	},
 	network => {
-	    order => 40,
+	    order => 45,
 	    cmds => [
 		'ip -details -statistics address',
 		'ip -details -4 route show',
-- 
2.30.2

[pve-devel] applied-series: [PATCH manager 0/2] minor improvements to pvereport

[Thomas Lamprecht]

Am 12/09/2022 um 15:37 schrieb Stoiko Ivanov:
> these two patches add small improvements to pvereport
> 
> Stoiko Ivanov (2):
>   report: add proxmox-boot-tool status output
>   report: stabilize order of guests and network
> 
>  PVE/Report.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

applied series, thanks!