all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used
Date: Wed, 31 Aug 2022 14:46:10 +0200	[thread overview]
Message-ID: <20220831124610.785526-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20220831124610.785526-1-f.ebner@proxmox.com>

which can lead to operations like cloning the running VM failing.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4e85dd02..3d7d70c5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3633,6 +3633,8 @@ sub config_to_command {
 
 	push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code";
 	push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=${path}${read_only_str}";
+    } elsif ($conf->{efidisk0}) {
+	log_warn("EFI disk was not attached, because SeaBIOS is used");
     }
 
     if ($q35) { # tell QEMU to load q35 config early
-- 
2.30.2





  reply	other threads:[~2022-08-31 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 12:46 [pve-devel] [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible Fiona Ebner
2022-08-31 12:46 ` Fiona Ebner [this message]
2022-09-26  9:40   ` [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used Thomas Lamprecht
2022-09-26  9:40 ` [pve-devel] applied: [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831124610.785526-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal