all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible
Date: Wed, 31 Aug 2022 14:46:09 +0200	[thread overview]
Message-ID: <20220831124610.785526-1-f.ebner@proxmox.com> (raw)

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

(build-)dependency bump for libpve-common-perl >= 7.1-4 needed

 PVE/QemuServer.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c706653b..4e85dd02 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -36,6 +36,7 @@ use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option parse_property_string);
 use PVE::ProcFSTools;
 use PVE::PBSClient;
+use PVE::RESTEnvironment qw(log_warn);
 use PVE::RPCEnvironment;
 use PVE::Storage;
 use PVE::SysFSTools;
@@ -3611,7 +3612,7 @@ sub config_to_command {
 
 	    $read_only_str = ',readonly=on' if drive_is_read_only($conf, $d);
 	} else {
-	    warn "no efidisk configured! Using temporary efivars disk.\n";
+	    log_warn("no efidisk configured! Using temporary efivars disk.");
 	    $path = "/tmp/$vmid-ovmf.fd";
 	    PVE::Tools::file_copy($ovmf_vars, $path, -s $ovmf_vars);
 	    $format = 'raw';
-- 
2.30.2





             reply	other threads:[~2022-08-31 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 12:46 Fiona Ebner [this message]
2022-08-31 12:46 ` [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used Fiona Ebner
2022-09-26  9:40   ` Thomas Lamprecht
2022-09-26  9:40 ` [pve-devel] applied: [PATCH qemu-server 1/2] config2cmd: make missing EFI disk warning more visible Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831124610.785526-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal