From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 1/1] ui: improve form/MDevSelector
Date: Fri, 12 Aug 2022 11:29:51 +0200 [thread overview]
Message-ID: <20220812092951.2053040-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220812092951.2053040-1-d.csapak@proxmox.com>
by
* showing the (optional) name in front of the type
* making the 'availble' column a bit narrower
* enabling 'cellWrap' for the description
* making the dropdown a bit wider (so all the information can fit)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/MDevSelector.js | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/MDevSelector.js b/www/manager6/form/MDevSelector.js
index 8ee73c0c..0a157813 100644
--- a/www/manager6/form/MDevSelector.js
+++ b/www/manager6/form/MDevSelector.js
@@ -16,21 +16,29 @@ Ext.define('PVE.form.MDevSelector', {
valueField: 'type',
displayField: 'type',
listConfig: {
+ width: 550,
columns: [
{
header: gettext('Type'),
dataIndex: 'type',
+ renderer: function(value, md, rec) {
+ if (rec.data.name !== undefined) {
+ return `${rec.data.name} (${value})`;
+ }
+ return value;
+ },
flex: 1,
},
{
- header: gettext('Available'),
+ header: gettext('Avail.'),
dataIndex: 'available',
- width: 80,
+ width: 60,
},
{
header: gettext('Description'),
dataIndex: 'description',
flex: 1,
+ cellWrap: true,
renderer: function(value) {
if (!value) {
return '';
--
2.30.2
next prev parent reply other threads:[~2022-08-12 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 9:29 [pve-devel] [PATCH common/qemu-server/manager v2] improve vGPU (mdev) usage for NVIDIA Dominik Csapak
2022-08-12 9:29 ` [pve-devel] [PATCH common v2 1/1] SysFSTools: get name from mediated device types Dominik Csapak
2022-08-12 12:02 ` [pve-devel] applied: " Wolfgang Bumiller
2022-08-12 9:29 ` [pve-devel] [PATCH qemu-server v2 1/2] automatically add 'uuid' parameter when passing through NVIDIA vGPU Dominik Csapak
2022-08-12 12:04 ` [pve-devel] applied: " Wolfgang Bumiller
2022-08-16 22:57 ` DERUMIER, Alexandre
2022-08-12 9:29 ` [pve-devel] [PATCH qemu-server v2 2/2] cleanup pci devices in more situations Dominik Csapak
2022-08-12 9:29 ` Dominik Csapak [this message]
2022-08-12 12:07 ` [pve-devel] applied: [PATCH manager v2 1/1] ui: improve form/MDevSelector Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812092951.2053040-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal