From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com, Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-container 0/3] fix #3711: delete LXC container with missing storage
Date: Mon, 25 Jul 2022 15:31:18 +0200 [thread overview]
Message-ID: <20220725133118.rd75siwly4aoih4j@casey.proxmox.com> (raw)
In-Reply-To: <e53cf62c-55fc-6b8e-cc78-3ad19cdee77e@proxmox.com>
On Mon, Jul 25, 2022 at 12:40:21PM +0200, Fiona Ebner wrote:
> Am 20.07.22 um 16:49 schrieb Stefan Hrdlicka:
> > The patch adds a new option 'force-remove-storage' that stops pct
> > destory from dying if the storage is not available. This also adds a
> > menu option for the delete dialog of containers.
> >
>
> VMs are also affected, so we probably want the new option there too.
> Although for VMs, it is possible to work around the issue by detaching
> all non-existing disks first.
Yeah, this is really mostly an issue with the `rootfs`, since you cannot
detach or remove it, so I think we could have this for VMs just for
consistency's sake.
> So slightly related: when detaching a disk and the owner of the volume
> is different (it also happens when the storage/disk does not exist
> anymore), we drop the disk for VMs, but we register it as unused for
> containers. Should we make that consistent?
Yeah I think consistency makes more sense there as well.
next prev parent reply other threads:[~2022-07-25 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 14:49 Stefan Hrdlicka
2022-07-20 14:49 ` [pve-devel] [PATCH pve-container 1/3] fix #3711: enable delete of LXC container via force option Stefan Hrdlicka
2022-07-22 12:25 ` Wolfgang Bumiller
2022-07-20 14:49 ` [pve-devel] [PATCH pve-container 2/3] fix #3711 cleanup: remove spaces from empty lines Stefan Hrdlicka
2022-07-22 12:26 ` Wolfgang Bumiller
2022-07-20 14:49 ` [pve-devel] [PATCH pve-manager 3/3] fix #3711: enable removing container with non existent storage Stefan Hrdlicka
2022-07-25 10:40 ` [pve-devel] [PATCH pve-container 0/3] fix #3711: delete LXC container with missing storage Fiona Ebner
2022-07-25 13:31 ` Wolfgang Bumiller [this message]
2022-08-05 12:05 ` Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725133118.rd75siwly4aoih4j@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal