From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui v2] StatTimeSelector: don't show invalid month/day combinations
Date: Fri, 1 Jul 2022 10:03:24 +0200 [thread overview]
Message-ID: <20220701080324.1750557-1-d.csapak@proxmox.com> (raw)
by limiting the store of the day selector by the selected month
reported by a user in the forum:
https://forum.proxmox.com/threads/wrong-calendar.111631/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* use js 'Date' to correctly calculate the last day of the month
including leapyears, etc.
js/StatTimeSelector.js | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/js/StatTimeSelector.js b/js/StatTimeSelector.js
index f01b058..eae2d91 100644
--- a/js/StatTimeSelector.js
+++ b/js/StatTimeSelector.js
@@ -73,7 +73,25 @@ Ext.define('PMG.StatTimeSelector', {
Ext.GlobalEvents.fireEvent('pmgStatTimeSelectorUpdate', data);
},
+ updateDays: function() {
+ let yearsel = this.lookupReference('yearsel');
+ let monthsel = this.lookupReference('monthsel');
+ let daysel = this.lookupReference('daysel');
+ let year = yearsel.getValue();
+ let month = monthsel.getValue();
+ // create a date for the next month, but day 0 which wraps to
+ // the last day of the current month. Our month is already
+ // 1 greater than what Date expects, so we don't have to add 1
+ let maxDays = new Date(year, month, 0).getDate();
+ daysel.getStore().setFilters([{
+ property: 'day',
+ operator: '<=',
+ value: maxDays,
+ }]);
+ },
+
onSelect: function() {
+ this.updateDays();
this.updateVisibility();
},
--
2.30.2
next reply other threads:[~2022-07-01 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 8:03 Dominik Csapak [this message]
2022-07-01 9:32 ` Thomas Lamprecht
2022-07-01 9:57 ` Dominik Csapak
2022-07-01 11:36 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701080324.1750557-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.