all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall
Date: Wed, 29 Jun 2022 11:08:27 +0200	[thread overview]
Message-ID: <20220629090833.456340-1-aderumier@odiso.com> (raw)

Hi,

I was doing some profiling of qm && pct command,
and I have found around 100ms cpu time just for the
use of PVE::Firewall in qemu-server && pve-container
for 2 small helpers. (clone_vmfw_conf && remove_vmfw_conf)

as PVE::Firewall require QemuServer && LXC,
we are loading full lxc in qm too.

Also, LXC have some include of PVE::Firewall
in different packages, not used,
but it was magically including QemuServer,
which including the json schema "pve-targetstorage",
used by lxc too.

I have moved this schema to main jsonschema in pve-common


Alexandre Derumier (1):
  schema: add pve-targetstorage (moved from qemu-server)

 src/PVE/JSONSchema.pm | 7 +++++++
 1 file changed, 7 insertions(+)

-- 

Alexandre Derumier (1):
  move clone_vmfw_conf && remove_vmfw_conf to a Helpers

 src/PVE/Firewall.pm         | 25 ----------------------
 src/PVE/Firewall/Helpers.pm | 41 +++++++++++++++++++++++++++++++++++++
 src/PVE/Firewall/Makefile   | 12 +++++++++++
 src/PVE/Makefile            |  2 ++
 4 files changed, 55 insertions(+), 25 deletions(-)
 create mode 100644 src/PVE/Firewall/Helpers.pm
 create mode 100644 src/PVE/Firewall/Makefile

-- 

Alexandre Derumier (2):
  api2: use firewall helpers
  qemu-server: remove json schema pve-targetstorage (moved to
    pve-common)

 PVE/API2/Qemu.pm  | 8 ++++----
 PVE/QemuServer.pm | 7 -------
 2 files changed, 4 insertions(+), 11 deletions(-)

-- 

Alexandre Derumier (2):
  remove unused use PVE::Firewall
  api2 : use firewall helpers

 src/PVE/API2/LXC.pm          | 10 +++++-----
 src/PVE/API2/LXC/Config.pm   |  1 -
 src/PVE/API2/LXC/Snapshot.pm |  1 -
 src/PVE/API2/LXC/Status.pm   |  1 -
 4 files changed, 5 insertions(+), 8 deletions(-)

-- 
2.30.2




             reply	other threads:[~2022-06-29  9:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  9:08 Alexandre Derumier [this message]
2022-06-29  9:08 ` [pve-devel] [PATCH qemu-server 1/2] api2: use firewall helpers Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH pve-firewall 1/1] move clone_vmfw_conf && remove_vmfw_conf to a Helpers Alexandre Derumier
2022-11-16 17:09   ` [pve-devel] applied: " Thomas Lamprecht
2022-06-29  9:08 ` [pve-devel] [PATCH pve-container 1/2] remove unused use PVE::Firewall Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server) Alexandre Derumier
2022-06-29  9:34   ` Thomas Lamprecht
2022-06-29  9:46     ` Fabian Ebner
2022-06-29  9:48       ` Thomas Lamprecht
2022-06-30  7:30     ` DERUMIER, Alexandre
2022-06-30  7:51       ` Thomas Lamprecht
2022-06-29  9:08 ` [pve-devel] [PATCH pve-container 2/2] api2 : use firewall helpers Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH qemu-server 2/2] qemu-server: remove json schema pve-targetstorage (moved to pve-common) Alexandre Derumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629090833.456340-1-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal