From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v7 qemu-server 05/10] generate cloudinit drive on offline plug
Date: Wed, 22 Jun 2022 13:52:01 +0200 [thread overview]
Message-ID: <20220622115206.3295425-6-aderumier@odiso.com> (raw)
In-Reply-To: <20220622115206.3295425-1-aderumier@odiso.com>
Currently when only generate it at vm start
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
PVE/QemuServer.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6cecf04..6310a41 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5103,6 +5103,8 @@ sub vmconfig_apply_pending {
PVE::QemuConfig->cleanup_pending($conf);
+ my $generate_cloudnit = undef;
+
foreach my $opt (keys %{$conf->{pending}}) { # add/change
next if $opt eq 'delete'; # just to be sure
eval {
@@ -5113,12 +5115,19 @@ sub vmconfig_apply_pending {
if (my $err = $@) {
$add_apply_error->($opt, $err);
} else {
+
+ if (is_valid_drivename($opt)) {
+ my $drive = parse_drive($opt, $conf->{pending}->{$opt});
+ $generate_cloudnit = 1 if drive_is_cloudinit($drive);
+ }
+
$conf->{$opt} = delete $conf->{pending}->{$opt};
}
}
# write all changes at once to avoid unnecessary i/o
PVE::QemuConfig->write_config($vmid, $conf);
+ PVE::QemuServer::Cloudinit::generate_cloudinitconfig($conf, $vmid) if $generate_cloudnit;
}
sub vmconfig_update_net {
--
2.30.2
next prev parent reply other threads:[~2022-06-22 11:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 11:51 [pve-devel] [PATCH v7 qemu-server 00/10] cloudinit pending behaviour change Alexandre Derumier
2022-06-22 11:51 ` [pve-devel] [PATCH v7 qemu-server 01/10] qemuconfig: load_current_config : delete cloudinit value Alexandre Derumier
2022-06-22 11:51 ` [pve-devel] [PATCH v7 qemu-server 02/10] vzdump : skip special:cloudinit section Alexandre Derumier
2022-06-22 11:51 ` [pve-devel] [PATCH v7 qemu-server 03/10] migration: test targetnode min version for cloudinit section Alexandre Derumier
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 04/10] cloudinit: add cloudinit section for current generated config Alexandre Derumier
2022-06-22 11:52 ` Alexandre Derumier [this message]
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 06/10] cloudinit: make cloudnit options fastplug Alexandre Derumier
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 07/10] api2: add cloudinit config api Alexandre Derumier
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 08/10] api2: add cloudinit_update Alexandre Derumier
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 09/10] add cloudinit hotplug Alexandre Derumier
2022-06-22 11:52 ` [pve-devel] [PATCH v7 qemu-server 10/10] debian : control : add a break on pve-manager <= 7.2.4 Alexandre Derumier
2022-06-23 7:22 ` Fabian Ebner
2022-06-23 7:59 ` DERUMIER, Alexandre
2022-07-27 11:19 ` [pve-devel] [PATCH v7 qemu-server 00/10] cloudinit pending behaviour change Fiona Ebner
2022-08-31 9:40 ` DERUMIER, Alexandre
2022-09-02 12:54 ` Fiona Ebner
2022-09-02 16:42 ` DERUMIER, Alexandre
[not found] ` <mailman.41.1662364805.354.pve-devel@lists.proxmox.com>
2022-09-06 7:24 ` DERUMIER, Alexandre
2022-11-08 16:44 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622115206.3295425-6-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.