From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu 2/3] vma: create: avoid triggering assertion in error case
Date: Wed, 22 Jun 2022 10:45:12 +0200 [thread overview]
Message-ID: <20220622084513.160867-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20220622084513.160867-1-f.ebner@proxmox.com>
error_setg expects its argument to not be initialized yet.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v2.
vma-writer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vma-writer.c b/vma-writer.c
index 11d8321ffd..29567cba68 100644
--- a/vma-writer.c
+++ b/vma-writer.c
@@ -310,6 +310,8 @@ VmaWriter *vma_writer_create(const char *filename, uuid_t uuid, Error **errp)
}
if (vmaw->fd < 0) {
+ error_free(*errp);
+ *errp = NULL;
error_setg(errp, "can't open file %s - %s\n", filename,
g_strerror(errno));
goto err;
--
2.30.2
next prev parent reply other threads:[~2022-06-22 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 8:45 [pve-devel] [PATCH-SERIES v2 qemu] vma/alloc-track improvements Fabian Ebner
2022-06-22 8:45 ` [pve-devel] [PATCH v2 qemu 1/3] vma: create: support 64KiB-unaligned input images Fabian Ebner
2022-06-22 8:45 ` Fabian Ebner [this message]
2022-06-22 8:45 ` [pve-devel] [PATCH v2 qemu 3/3] block: alloc-track: avoid premature break Fabian Ebner
2022-06-22 15:31 ` [pve-devel] applied: [PATCH-SERIES v2 qemu] vma/alloc-track improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622084513.160867-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal