* [pbs-devel] [PATCH proxmox-backup] restore-daemon: make file listing 'streaming'
@ 2022-06-20 7:51 Dominik Csapak
2022-06-21 8:48 ` [pbs-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-06-20 7:51 UTC (permalink / raw)
To: pbs-devel
this prevents an oom kill when listing large directories.
Without this, i'd get an oom kill in the restore vm when
i tried to list a directory with ~60000 entries, but with this,
i'd get the response for even 250000 entries
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
at 250000 files, the gui did not work anymore, but that's a different
problem altogether (i got 'Maximum call stack size exceeded' in extjs code)
proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
index aeb5a71d..91afe5e3 100644
--- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
+++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
@@ -116,6 +116,7 @@ fn get_dir_entry(path: &Path) -> Result<DirEntryAttribute, Error> {
}
#[api(
+ streaming: true,
input: {
properties: {
"path": {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] restore-daemon: make file listing 'streaming'
2022-06-20 7:51 [pbs-devel] [PATCH proxmox-backup] restore-daemon: make file listing 'streaming' Dominik Csapak
@ 2022-06-21 8:48 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2022-06-21 8:48 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pbs-devel
applied, thanks
On Mon, Jun 20, 2022 at 09:51:13AM +0200, Dominik Csapak wrote:
> this prevents an oom kill when listing large directories.
> Without this, i'd get an oom kill in the restore vm when
> i tried to list a directory with ~60000 entries, but with this,
> i'd get the response for even 250000 entries
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> at 250000 files, the gui did not work anymore, but that's a different
> problem altogether (i got 'Maximum call stack size exceeded' in extjs code)
>
> proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> index aeb5a71d..91afe5e3 100644
> --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> @@ -116,6 +116,7 @@ fn get_dir_entry(path: &Path) -> Result<DirEntryAttribute, Error> {
> }
>
> #[api(
> + streaming: true,
> input: {
> properties: {
> "path": {
> --
> 2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 7:51 [pbs-devel] [PATCH proxmox-backup] restore-daemon: make file listing 'streaming' Dominik Csapak
2022-06-21 8:48 ` [pbs-devel] applied: " Wolfgang Bumiller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal