From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied series: [PATCH storage v4 1/4] fix #3972: Remove the .notes file when a backup is deleted
Date: Wed, 15 Jun 2022 10:52:10 +0200 [thread overview]
Message-ID: <20220615085210.yajtniz67kwutxgi@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20220614090013.84500-1-d.tschlatscher@proxmox.com>
applied series and removed the empty lines between the S-o-b and R-b
lines.
On Tue, Jun 14, 2022 at 11:00:10AM +0200, Daniel Tschlatscher wrote:
> When a VM or Container backup was deleted, the .notes file was not
> removed, therefore, over time the dump folder would get polluted with
> notes for backups that no longer existed. As backup names contain a
> timestamp and as the notes cannot be reused because of this, I think
> it is safe to just delete them just like we do with the .log file.
>
> Furthermore, I sourced the deletion of the log and notes file into a
> new function called "archive_auxiliaries_remove". Additionally, the
> archive_info object now returns one more field containing the name of
> the notes file. The test cases have to be adapted to expect this new
> value as the package will not compile otherwise.
>
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
prev parent reply other threads:[~2022-06-15 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:00 [pve-devel] " Daniel Tschlatscher
2022-06-14 9:00 ` [pve-devel] [PATCH storage v4 2/4] Adapted unlink calls for archive files in case of ENOENT Daniel Tschlatscher
2022-06-14 9:00 ` [pve-devel] [PATCH storage v4 3/4] Switched to using log_warn of PVE::RESTEnvironment Daniel Tschlatscher
2022-06-14 9:00 ` [pve-devel] [PATCH storage v4 4/4] Added a LOG_EXT constant as a counterpart to NOTES_EXT Daniel Tschlatscher
2022-06-15 8:52 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615085210.yajtniz67kwutxgi@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.