From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter
Date: Fri, 27 May 2022 10:22:01 +0200 [thread overview]
Message-ID: <20220527082203.1653182-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220527082203.1653182-1-d.csapak@proxmox.com>
we always want the restore_list to use a timeout here. Set it to 25 seconds
so there is a little headroom between this and pveproxys 30s one.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index 37385d7..7eaace3 100644
--- a/src/PVE/PBSClient.pm
+++ b/src/PVE/PBSClient.pm
@@ -378,7 +378,7 @@ sub file_restore_list {
return run_client_cmd(
$self,
"list",
- [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0 ],
+ [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0, '--timeout', 25],
0,
"proxmox-file-restore",
$namespace,
--
2.30.2
WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter
Date: Fri, 27 May 2022 10:22:01 +0200 [thread overview]
Message-ID: <20220527082203.1653182-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220527082203.1653182-1-d.csapak@proxmox.com>
we always want the restore_list to use a timeout here. Set it to 25 seconds
so there is a little headroom between this and pveproxys 30s one.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index 37385d7..7eaace3 100644
--- a/src/PVE/PBSClient.pm
+++ b/src/PVE/PBSClient.pm
@@ -378,7 +378,7 @@ sub file_restore_list {
return run_client_cmd(
$self,
"list",
- [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0 ],
+ [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0, '--timeout', 25],
0,
"proxmox-file-restore",
$namespace,
--
2.30.2
next prev parent reply other threads:[~2022-05-27 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:22 [pve-devel] [PATCH common/storage/proxmxo-backup v3] improve file-restore timeout behaviour Dominik Csapak
2022-05-27 8:22 ` [pbs-devel] " Dominik Csapak
2022-05-27 8:22 ` Dominik Csapak [this message]
2022-05-27 8:22 ` [pbs-devel] [PATCH common v3 1/1] PBSClient: file_restore_list: add timeout parameter Dominik Csapak
2022-11-07 14:17 ` [pve-devel] " Thomas Lamprecht
2022-11-07 14:17 ` [pbs-devel] " Thomas Lamprecht
2022-11-08 11:20 ` Dominik Csapak
2022-11-08 11:20 ` [pbs-devel] " Dominik Csapak
2022-11-08 15:53 ` Thomas Lamprecht
2022-11-08 15:53 ` [pbs-devel] " Thomas Lamprecht
2022-11-09 7:07 ` Dominik Csapak
2022-11-09 7:07 ` [pbs-devel] " Dominik Csapak
2022-05-27 8:22 ` [pve-devel] [PATCH storage v3 1/1] api: FileRestore: decode and return proper error with new file-restore params Dominik Csapak
2022-05-27 8:22 ` [pbs-devel] " Dominik Csapak
2022-05-27 8:22 ` [pve-devel] [PATCH proxmox-backup v3 1/1] file-restore: remove 'json-error' parameter from list_files Dominik Csapak
2022-05-27 8:22 ` [pbs-devel] " Dominik Csapak
2022-10-05 17:34 ` [pve-devel] applied: " Thomas Lamprecht
2022-10-05 17:34 ` [pbs-devel] applied: " Thomas Lamprecht
2022-10-25 10:17 ` [pve-devel] [PATCH common/storage/proxmxo-backup v3] improve file-restore timeout behaviour Dominik Csapak
2022-10-25 10:17 ` [pbs-devel] " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527082203.1653182-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal