all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: don't send 'id' on edit
@ 2022-05-17  7:05 Dominik Csapak
  2022-05-17  7:52 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-05-17  7:05 UTC (permalink / raw)
  To: pbs-devel

we cannot change the id, and even if we send the same, the backend
does not allow 'duplicate' parameters (the id is in the url already)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/SyncJobEdit.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 2c09b354..8e33265b 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -228,6 +228,10 @@ Ext.define('PBS.window.SyncJobEdit', {
 			name: 'id',
 			allowBlank: true,
 			regex: PBS.Utils.SAFE_ID_RE,
+			cbind: {
+			    disabled: '{!isCreate}',
+			    hidden: '{!isCreate}',
+			},
 		    },
 		],
 	    },
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: window/SyncJobEdit: don't send 'id' on edit
  2022-05-17  7:05 [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: don't send 'id' on edit Dominik Csapak
@ 2022-05-17  7:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-05-17  7:52 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

Am 5/17/22 um 09:05 scriber Dominik Csapak:
> we cannot change the id, and even if we send the same, the backend
> does not allow 'duplicate' parameters (the id is in the url already)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/window/SyncJobEdit.js | 4 ++++
>  1 file changed, 4 insertions(+)
> 
>

applied, thanks!

But change this to a displayEdit field instead to avoid having a advanced checkbox/area but
no field in there shown and also fixed verify jobs, which had the same problem..




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-17  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17  7:05 [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: don't send 'id' on edit Dominik Csapak
2022-05-17  7:52 ` [pbs-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal