From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/5] ui: form/NamespaceSelector: show proper emptyText
Date: Tue, 17 May 2022 08:52:12 +0200 [thread overview]
Message-ID: <20220517065215.327699-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220517065215.327699-1-d.csapak@proxmox.com>
by filtering out the empty namespace from the api, and putting the
correct div with xclass around the gettext
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/form/NamespaceSelector.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/form/NamespaceSelector.js b/www/form/NamespaceSelector.js
index 44b7ca0d..c847cd4e 100644
--- a/www/form/NamespaceSelector.js
+++ b/www/form/NamespaceSelector.js
@@ -34,8 +34,8 @@ Ext.define('PBS.form.NamespaceSelector', {
minWidth: 170,
maxWidth: 500,
// below doesn't work :/
- //minHeight: 30,
- //emptyText: gettext('No namespaces accesible.'),
+ minHeight: 30,
+ emptyText: `<div class="x-grid-empty">${gettext('No namespaces accessible.')}</div>`,
},
triggers: {
@@ -82,6 +82,7 @@ Ext.define('PBS.form.NamespaceSelector', {
me.store = Ext.create('Ext.data.Store', {
model: 'pbs-namespaces',
autoLoad: !!me.datastore,
+ filters: (rec) => rec.data.ns !== '',
proxy: {
type: 'proxmox',
timeout: 30 * 1000,
--
2.30.2
next prev parent reply other threads:[~2022-05-17 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 6:52 [pbs-devel] [PATCH proxmox-backup 1/5] tape/pool_writer: give proper types to 'contains_snapshot' Dominik Csapak
2022-05-17 6:52 ` Dominik Csapak [this message]
2022-05-17 11:41 ` [pbs-devel] applied: [PATCH proxmox-backup 2/5] ui: form/NamespaceSelector: show proper emptyText Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: form/DataStoreSelector: show maintenance mode in selector Dominik Csapak
2022-05-17 8:53 ` [pbs-devel] applied: " Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore/Summary: change storage axis to power of two Dominik Csapak
2022-05-17 8:09 ` Thomas Lamprecht
2022-05-17 8:20 ` Dominik Csapak
2022-05-17 8:32 ` Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: SyncView/SyncJobEdit: unify store/namespace gettext Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517065215.327699-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal