all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] gui: VM Create wizard - display default scsi controller correctly
@ 2022-05-12 10:00 Daniel Tschlatscher
  2022-05-12 14:32 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Tschlatscher @ 2022-05-12 10:00 UTC (permalink / raw)
  To: pve-devel

Fixed a cosmetic issue where in the VM creation wizard the SCSI
controller would not be displayed correctly if the default value
"Default (LSI 53C895A)" was selected. In this case, "__default__"
would be printed for the user in the next pane.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
 www/manager6/Utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index b4e2df79..8276e95c 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -508,7 +508,7 @@ Ext.define('PVE.Utils', {
     render_as_property_string: v => !v ? Proxmox.Utils.defaultText : PVE.Parser.printPropertyString(v),
 
     render_scsihw: function(value) {
-	if (!value) {
+	if (!value || value === '__default__') {
 	    return Proxmox.Utils.defaultText + ' (LSI 53C895A)';
 	} else if (value === 'lsi') {
 	    return 'LSI 53C895A';
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] gui: VM Create wizard - display default scsi controller correctly
  2022-05-12 10:00 [pve-devel] [PATCH manager] gui: VM Create wizard - display default scsi controller correctly Daniel Tschlatscher
@ 2022-05-12 14:32 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-05-12 14:32 UTC (permalink / raw)
  To: Proxmox VE development discussion, Daniel Tschlatscher

Am 5/12/22 um 12:00 schrieb Daniel Tschlatscher:
> Fixed a cosmetic issue where in the VM creation wizard the SCSI
> controller would not be displayed correctly if the default value
> "Default (LSI 53C895A)" was selected. In this case, "__default__"
> would be printed for the user in the next pane.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
>  www/manager6/Utils.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-12 14:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 10:00 [pve-devel] [PATCH manager] gui: VM Create wizard - display default scsi controller correctly Daniel Tschlatscher
2022-05-12 14:32 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal