all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-perl-rs] common: d/control: break/replace libpve-rs-perl (<< 0.6.0)
Date: Mon,  9 May 2022 12:17:51 +0200	[thread overview]
Message-ID: <20220509101751.1520625-1-s.ivanov@proxmox.com> (raw)

libproxmox-rs-perl ships /usr/share/perl5/PVE/RS/CalendarEvent.pm,
which was also present in libpve-rs-perl until version 0.5.1

This can lead to a (racy) issue while upgrading - depending
on which of libproxmox-rs-perl or libpve-rs-perl gets unpacked first
we potentially run into:
```
dpkg: error processing archive \
/tmp/apt-dpkg-install-lNBzMn/48-libproxmox-rs-perl_0.1.0_amd64.deb (--unpack):
 trying to overwrite '/usr/share/perl5/PVE/RS/CalendarEvent.pm', \
 which is also in package libpve-rs-perl 0.5.1
```

This patch follows the debian policy manual for these situations:
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-breaks

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
Sadly was not able to trigger this issue on any of my systems (and a VM with
a fresh 7.1 ISO install).

 common/pkg/debian/control | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/pkg/debian/control b/common/pkg/debian/control
index cdda8c5..8bc510c 100644
--- a/common/pkg/debian/control
+++ b/common/pkg/debian/control
@@ -17,6 +17,8 @@ Depends:
  ${perl:Depends},
  ${shlibs:Depends},
  libpve-rs-perl (>= 0.6.0) | libpmg-rs-perl (>= 0.5.0),
+Breaks: libpve-rs-perl (<< 0.6.0)
+Replaces: libpve-rs-perl (<< 0.6.0)
 Description: PVE/PMG common parts which have been ported to Rust - Perl packages
  Contains the perl side of modules provided by the libraries of both libpve-rs-perl and
  libpmg-rs-perl, loading whichever is available.
-- 
2.30.2





             reply	other threads:[~2022-05-09 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 10:17 Stoiko Ivanov [this message]
2022-05-09 14:49 ` Fabian Grünbichler
2022-05-10  5:16 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509101751.1520625-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal